Ignore notifications in case of data corruption
Background / User story
After a notification has been shown, the extension will mark it as such, in order to not show it again. However, it cannot do so for users who are experiencing data corruption problems. Therefore we should not show notifications, if we have detected any such problems.
There are some exceptions, though, because we want to continue to be able to notify users about the data corruption as well as about other critical topics. The latter cannot be dismissed anyway
What to change
- Design: N/A
- Research: N/A
- Spec: https://gitlab.com/eyeo/specs/spec/-/merge_requests/346
- Legal: https://jira.eyeo.com/browse/ABPUI-38
-
Development:
- If extension identified a data corruption problem, it should not show any notifications, except:
- Notifications with ID "problem".
- Notifications with type "critical".
- If extension identified a data corruption problem, it should not show any notifications, except:
Hints for testers
No changes to adblockplusui have been made.
Hints for translators
N/A
Integration notes
Requires eyeo/adblockplus/adblockpluschrome#244 (closed) and https://gitlab.com/eyeo/adblockplus/adblockpluscore/-/issues/247.
Further information
We may be able to extend the shouldIgnoreNotifications()
function, which is currently only used to enforce the user's preference to not see notifications.