Manifest v3: Delay when pasting multiple custom filters
Environment
- OS version: Ubuntu 22.04
- Browser version: Chrome 121
- Extension version: Adblock Plus 3.24.11180
- Last working version: Adblock Plus 3.24.11170
Steps to reproduce
- Add custom filter
aaaa
. - Copy the following custom filters and paste them into the input field to add them:
bbbb
cccc
dddd
eeee
ffff
gggg
hhhh
iiii
jjjj
kkkk
llll
mmmm
nnnn
Observed behavior
After 2)
- First custom filter gets added immediately.
- Other custom filters get added all at once after some noticable delay.
Expected behavior
After 2) All custom filters should get added immediately.
Further information
This issue was originally reported by an internal user.
We add custom filters one at a time and we usually want custom filters to be applied immediately. As this is a costly operation under Manifest v3, this seems to cause subsequent filters to have to wait until the first filter got added.
Hints for testers
- Adding and removing multiple custom filters at once should now be much more performant, but should continue to work as expected, including:
- Pasting the content of a filter list (incl. filter list header)
- Pasting multiple filters that include invalid ones
- Adding/removing custom filters should continue to work as expected elsewhere (e.g. un-/allowlisting pages, "Block element" feature).