Sedictious commented on merge request !1 at AcubeSAT / Communications / Software / BCH-sandbox

Sedictious
2022-03-22T20:05:57Z

We are waiting for the documentation fix you suggested, but @NikosStrimpas86 also made a point about possibly syndromesHash throwing an Exception (exceptions should be disabled so we should be worried about undefined behaviour instead). However (unless I'm mistaken), the only point this could happen in is here (syndromesHash.at(syndrome1)), which should be handled by the check above else if (syndromesHash.contains(syndrome1))

Also sandbox is a misleading name. This could be a flight repo (albeit as an alternative to the FPGA implementation) so keep this in mind in case you want to go back and do a more in-depth review - we discussed about changing the names of the <blah>-sandbox to just blah or integrating them to this repo (which is the solution I personally prefer)