Lib: don't use g_idle_add, respect thread affinity (!9) · Merge Requests · accounts-sso / libsignon-glib · GitLab

Lib: don't use g_idle_add, respect thread affinity

After commit 4e85baaf libsignon-glib stopped working when used in a thread on which g_main_context_push_thread_default() had been called: the reason is that g_idle_add()'s callback is always involved on the default GMainContext, and not on the one used by the current thread.

We fix this problem by using g_source directly. Fixes: https://bugs.launchpad.net/bugs/1607799

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved

Albert Astals Cid @albert-astals commented Aug 01, 2016

I can confirm it fixes said bug. Not much of a glib expert myself so can't comment on the code changes themselves

I can confirm it fixes said bug. Not much of a glib expert myself so can't comment on the code changes themselves
Alberto Mardegan @mardy
Added 1 commit:

b6a6cf0f - Tests: remove check for undefined case

Aug 02, 2016
Added 1 commit:

b6a6cf0f - Tests: remove check for undefined case
Added 1 commit: * b6a6cf0f - Tests: remove check for undefined case

Toggle commit list
Corentin Noël @tintou commented Aug 24, 2016

Master

Everything looks good here

Everything looks good here
Alberto Mardegan @mardy
Status changed to merged
Sep 27, 2016

Status changed to merged

Status changed to merged

Toggle commit list

Please register or to comment