Skip to content

Handle after-auth connection errors in VNC properly

Lorenz Brun requested to merge lorenz/Remmina:vnc-after-auth-errors into master

When connecting to gnome-remote-desktop the server aborts the connection after successful authentication if it can't establish a PipeWire session. Remmina's VNC plugin treats any connection failure after authentication has started as an authentication failure and wipes stored credentials.

Description

This change catches known network-related errors and flags them as not an authentication failure.

How Has This Been Tested?

This has been tested against a VNC server based on libvncserver set up with an unavailable backend and it didn't result in Remmina wiping credentials but showed a normal error. It has also been tested against a VNC server based on libvncserver with wrong credentials supplied by Remmina and it still prompted for credentials.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
Edited by Lorenz Brun

Merge request reports