Skip to content
Snippets Groups Projects

Scrolled Viewport: use viewport_motion_handler as the only timeout indicator

Merged Tianhao Chai requested to merge cth451/Remmina:scrolled_viewport_fix_scrolling into master

The boolean viewport_motion is removed in favor of directly using the source ID. Whenever the timeout callback function decides to return FALSE and stop further repeating timeout callbacks, set the source ID to zero to avoid cancelling a timeout that already vanished.

The previous find_source_by_funcs_user_data is insufficient to prevent this state discrepancy between glib and viewport struct and also prevents scrolling from actually happening, so it's removed.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading