Skip to content

[RFC][v2] RDP: Add Use base credential for RD gateway autentication

Fabio Fantoni requested to merge Fantu/Remmina:base-cred-for-gw into master

Even if rfi->settings->GatewayUseSameCredentials is TRUE (set when gw user/password/domain are empty) Remmina still request gw credentials in some cases. This is because GatewayUseSameCredentials in FreeRDP uses gateway credentials also for base, contrary to Remmina.

This patch adds a flag for choosing to use base credentials also for gateway credentials. In remmina_rdp_gw_authenticate use and save base credential if the new option is true. In remmina_rdp_main reset gateway credentials if the new option is true. Kept for backwards compability: the code for "auto" use base settings for gateway without this flag (that was working for the case where both base username and password are stored)

I want ask a question: For backwards compatibility, I kept the code about "auto" use base settings for gateway (that was working for the case where both base username and password are stored), or no good with the new flag?

Any other advice and improvements for the patch is appreciated.

Edited by Allan Nordhøy

Merge request reports