Skip to content

Cppcheck and PVS Studio Fixes

Rafał Mikrut requested to merge qarmin/Remmina:cppcheck_bugs into master

Hi, I found and fix some warnings/errors found by Cppcheck There are some variable renames in functions(was different in declarations and definitions), some null pointer checking and deleting unused variables.

I don't even compiled Remmina after this changes because I can't find any documentation how to do it(I found only old Travis Ubuntu 14.04 script but I use Ubuntu 19.10)

I don't dig into Remmina source code, so maybe most of this changes are bad.

Feel free to leave comment, fork this PR or even close it if changes are unnecessary.

Edited by Rafał Mikrut

Merge request reports