External tools broken?

Created by: thecrazy

None of the built in scripts work properly, they do run but the variables used in the examples: $ssh_username $password and $password are not set.

I could be wrong but from a quick search in the source code it seems remmina tries to source the .remmina file associated with the selected entry before running the script, unfortunatly the values dont seem to make it to the subshell running the script.

OR maybe the variable names are wrong. I tried to look for some documentation (googled a lot) but I couldn't find anything on remmina's external tool scripting. It would be nice if whoever works on this could confirm which variables are available for the wiki.

I am using Remmina 1.2.0-rcgit.3

Thank you for your good work.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Created by: thecrazy

External tools are accessible from the contextual menu when right clicking on an entry in the Main Window ( the list of remote servers ). I have not tested launching them from the tools above when a connection is already established but I will test. I would expect them to also work from the main window if they are accessible there.

Another detail, for SSH connections we cant save the password in remmina so its kind of weird that the script for sftp/filezilla expects a $password variable. Is a box supposed to pop up?

Created by: thecrazy

I took another look at remmina's main window (were you manage all the connections) and there is no "File" menu. What I have is Connection, Edit, View, Tools and Help.

I'm assuming you meant "external tool" under "Connection". I tried it but scripts launched from there also encounter the same problem with unset variables.

The same icon used for the "external tools" can also be found in the toolbar above active connections, the commands in there work fine but I am not sure it's even related to external tools as items in there are different and some of them (copy/paste) are definitly not scripts. Its a bit confusing that it shares the same icon.

I also tried installing gnome-terminal, restarted remmina, connected to a ssh server and then I ran external tools from the connection menu on the main window while the same ssh server was highlighted in the list of servers. Same problem.

I hope you guys will keep this functionality, being able to run custom scripts from within Remmina is a great feature.

Let me know if you want any more info.

Created by: thecrazy

Here is the stdout from the terminal running remmina:

(remmina:13401): Gtk-WARNING **: Theme parsing error: gtk.css:27:35: Junk at end of value

(remmina:13401): Gtk-WARNING **: Theme parsing error: gtk.css:40:48: Junk at end of value

(remmina:13401): Gtk-WARNING **: Theme parsing error: gtk.css:48:46: Junk at end of value

(remmina:13401): Gtk-WARNING **: Theme parsing error: gtk.css:59:58: Junk at end of value

(remmina:13401): Gtk-WARNING **: Theme parsing error: gtk.css:70:46: Junk at end of value

(remmina:13401): Gtk-WARNING **: Theme parsing error: gtk.css:81:58: Junk at end of value Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

And here is the stdout from the terminal that opens when running the external tool "filezilla_sftp.sh":

-ne Reading locale option from /home/fdefoy/.filezilla/filezilla.xml

(filezilla:13538): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed

(filezilla:13538): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'height >= -1' failed

(filezilla:13538): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed

(filezilla:13538): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed

(filezilla:13538): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'height >= -1' failed

(filezilla:13538): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width >= -1' failed wxD-Bus: Signal from /org/freedesktop/DBus, member NameAcquired wxD-Bus: Reply with serial 2 wxD-Bus: Signal: Error: The name org.gnome.SessionManager was not provided by any .service files wxD-Bus: CPowerManagementInhibitor: Requesting busy wxD-Bus: Reply with serial 3 wxD-Bus: CPowerManagementInhibitor: Request successful, cookie is 15 wxD-Bus: CPowerManagementInhibitor: Requesting idle wxD-Bus: Reply with serial 4 wxD-Bus: CPowerManagementInhibitor: Request successful

Really strange, I cannot reproduce your issue.

Which distribution (or OS) are you using? Which version?

Created by: thecrazy

Xubuntu 15.04

Can you confirm that ping, nslooukp and traceroute are not working?

Regarding filezilla you are right, using a password doesn't work.

If you need to transfer files via ssh, did you try the simple file transfer client included with remmina?

Open an SSH connection and click on the Tools icon, you should have "Open Secure File Transfer..."

We will see what we can do to fix the external tools, but it's not a priority at the moment.

WARNING: The Remmina project is moving to gitlab.com, in order to keep receiving notification about this issue, you should have a gitlab account and link it to github. The migration will happen in the next days. Thanks for your support and understanding.

cc @antenore @aplocher @douglasg14b @firefishy @giox069 @JeremyHargis @Jonathann @MAnand59 @matt-edu @mraoofnia @niallnsec @NipunaPrashan @shankervenkat @thecrazy

I can confirm this bug in xubuntu 18.04, external tools scripts does not get variables like $server... I tried also with remmina-next ppa, but the bug is still there.

@antenore I suggest to put the "bug" label

I found the problem: it work only with gnome-terminal in the file: /usr/share/remmina/external_tools/launcher.sh

if [ -x "/usr/bin/x-terminal-emulator" ];
then
 TERMNAME="/usr/bin/x-terminal-emulator"
else
 TERMNAME="gnome-terminal"
fi

if is installed x-terminal-emulator, it's selected as default, but no arguments will be passed.

so a possible workaround is:

sudo apt install gnome-terminal

and replace

if [ -x "/usr/bin/x-terminal-emulator" ];
then
 TERMNAME="/usr/bin/x-terminal-emulator"
else
 TERMNAME="gnome-terminal"
fi

with TERMNAME="gnome-terminal"

Another way to use xfce4-terminal is writing the following string into your launcher.sh.

/usr/bin/xfce4-terminal --disable-server -e "$1" &

And you need to comment default execution string of gnome-terminal. This issue caused because xfce4-terminal without additional parameter (--disable-server) looses all environment variables passed through to it.

Nice, can you submit a merge request?

It will take more time then I thought. In master branch launcher.sh is completely broken. So I need to install last remmina version instead of 1.4.2 and check it.

I have added a merge request.

It was not merged with an error unrelated with my changes.

@ivanomatteo thanks. How the tools work have to be rethink completely. Calling the "default" terminal change from distro to distro, and from wm to wm.

For instance x- terminal-emulator it's only on debian as far as I know, on Ubuntu you should have, not sure, xdg-terminal. On i3wm there's i3-sensible-terminal, and so forth...

The best would be to develop those tools in plain C

BTW if you have x-terminal-emulator, you can make it points to the right terminal with

# update-alternatives --config x-terminal-emulator

added bug label

@antenore I'm agree with you.

Anyway using a terminal is not that bad, but as you said x-terminal-emulator could be any terminal, and not all terminal app can be supported.

I think that a good solution is:

• add xterm as dependence
• add support for xterm (obviously)
• inside launcher make a switch case with a list of supported terminals,
• if no supported terminal is found, fallback to xterm

Hi,

I can confirm that the workaround from @ivanomatteo works in Xubuntu 18.04.

Closing as we will rethink the external tool completely.

Another issue will be submitted

closed

mentioned in merge request !2412 (merged)