1.4.32 does not build if ssh plugin is disabled

Ensure the problem exists on the first,
and keep trying to reproduce it on any later versions :)

• Reporting back greatly increases attention to and hope of fixing your issue.

Do not use GitLab for support requests, instead ask questions on:

• Matrix (the best way to reach us)
• Reddit
• IRC, on libera.chat, in the #remmina channel, or use a web client.

For enhancement requests select the proper Issue template in the above drop-down box.

Problem Description

Remmina 1.4.32 does not build if WITH_LIBSSH is disabled.

What is the expected correct behavior?

It should build.

Remote System Description

• Server (OS name and version): FreeBSD 13.2 amd54
• Special notes regarding the remote system (i.e. gateways, tunnel, etc.):

Relevant logs and/or screenshots

The error is

/wrkdirs/usr/ports/net/remmina/work-lite/Remmina-4804f68f23045a38c3a7be46810fce14bac2fc3c/src/remmina_file_editor.c:661:49: error: use of undeclared identifier 'remmina_file_editor_assistance_enabled_check_on_toggled'
        g_signal_connect(widget, "toggled", G_CALLBACK(remmina_file_editor_assistance_enabled_check_on_toggled), gfe);
                                                       ^
/wrkdirs/usr/ports/net/remmina/work-lite/Remmina-4804f68f23045a38c3a7be46810fce14bac2fc3c/src/remmina_file_editor.c:690:2: warning: implicit declaration of function 'remmina_file_editor_assistance_enabled_check_on_toggled' is invalid in C99 [-Wimplicit-function-declaration]
        remmina_file_editor_assistance_enabled_check_on_toggled(NULL, gfe);
        ^
1 warning and 1 error generated.

The problem is that the remmina_file_editor_assistance_enabled_check_on_toggled function is protected inside an #ifdef HAVE_LIBSSH block that gets deleted if WITH_LIBSSH is not used. But the code in remmina_file_editor_create_assistance uses that function inconditionally.

Debugging documentation

Please see Remmina debugging

Local System Description

• Client (OS name and version): FreeBSD 13.2

• Remmina version ( remmina --version ): 1.4.32

• Installation(s):

  • Distribution package.
  • PPA.
  • Snap.
  • Flatpak.
  • Compiled from sources.
  • Other - detail:

• Desktop environment (GNOME, Unity, KDE, ..):

• Plugin(s):

  • RDP - freerdp version ( xfreerdp --version ):
  • VNC
  • SSH
  • SFTP
  • SPICE
  • WWW
  • EXEC
  • Other (please specify):

• GTK backend (Wayland, Xorg): Xorg

• Optional: Include the output of the following commands at the end of this text:

  I can't since it does not build. Adding WITH_LIBSSH makes Remmina build fine.

Contributions

In return, or to fix this issue, I'd be willing to:

• Fix this myself.
• Donate ___ and/or have donated ___ towards fixing it.
• Take a donation of ___ to fix it.
• Update the documentation.
• Update the wiki.
• Translate Remmina in my native language(s) (___) on Hosted Weblate.