issue in rdp_plugin.c

Test on the latest version before submitting a bug-report, and keep trying to reproduce it on any later versions

• Reporting back greatly increases the attention and hope of fixing your issue.

You can also ask questions via

• IRC room, on freenode.net, in the #remmina channel, you can also use a web client.
• General discussion mailing list.
• Reddit

Local System Description

• Client (OS name and version): Arch Linux

• Remmina version ( 1.4.16 (git 7a67e161b) ):

• Installation:

  • Distribution package.
  • PPA.
  • Snap.
  • Flatpak.
  • Compiled from sources.
  • Other - detail:

• Desktop environment (GNOME, Unity, KDE, ..):

• Plugin:

  • RDP - freerdp version ( xfreerdp --version ):
  • VNC
  • SSH
  • SFTP
  • SPICE
  • WWW
  • EXEC
  • Other (please specify):

• GTK back-end (Wayland, Xorg):

• Optional: Include the output of the following commands at the end of this text:

  • remmina --full-version

Load modules from /usr/lib/remmina/plugins
Remmina plugin glibsecret (type=Secret) has been registered, but is not yet initialized/activated. The initialization order is 2000.
The glibsecret secret plugin  has been initialized and it will be your default secret plugin

org.remmina.Remmina - 1.4.16 (git 7a67e161b)

NAME                TYPE            DESCRIPTION                                                     PLUGIN AND LIBRARY VERSION
ANYDESK             Protocol        ANYDESK - Launch an Anydesk connection                          1.0.0.0   
EXEC                Protocol        Execute a command                                               1.0       
NX                  Protocol        NX - NX Technology                                              1.4.16    
RDESKTOP            Protocol        RDESKTOP - Open a RDP connection with rdesktop                  1.3.0.0   
RDP                 Protocol        RDP - Remote Desktop Protocol                                   RDP plugin: 1.4.16 (Git 7a67e161b), Compiled with libfreerdp 3.0.0-dev (9e466abe6), Running with libfreerdp 3.0.0-dev (rev 555944f02), H.264 Yes
RDPF                File            RDP - RDP File Handler                                          RDP plugin: 1.4.16 (Git 7a67e161b), Compiled with libfreerdp 3.0.0-dev (9e466abe6), Running with libfreerdp 3.0.0-dev (rev 555944f02), H.264 Yes
RDPS                Preference      RDP - Preferences                                               RDP plugin: 1.4.16 (Git 7a67e161b), Compiled with libfreerdp 3.0.0-dev (9e466abe6), Running with libfreerdp 3.0.0-dev (rev 555944f02), H.264 Yes
SPICE               Protocol        SPICE - Simple Protocol for Independent Computing Environments  1.4.16    
ST                  Protocol        Remmina simple terminal                                         1.0.0.0   
VNC                 Protocol        Remmina VNC Plugin                                              1.4.16    
VNCI                Protocol        Remmina VNC listener Plugin                                     1.4.16    
WWW                 Protocol        Remmina web-browser plugin                                      0.1.0     
XDMCP               Protocol        XDMCP - X Remote Session                                        1.4.16    
glibsecret          Secret          Secured password storage in the GNOME keyring                   1.4.16    

Build configuration: HAVE_ARPA_INET_H=1 HAVE_ERRNO_H=1 HAVE_FCNTL_H=1 HAVE_NETDB_H=1 HAVE_NETINET_IN_H=1 HAVE_NETINET_TCP_H=1 HAVE_SYS_SOCKET_H=1 HAVE_SYS_UN_H=1 HAVE_TERMIOS_H=1 HAVE_UNISTD_H=1 WITH_APPINDICATOR=ON WITH_AVAHI=ON WITH_FREERDP3=ON WITH_GCRYPT=ON WITH_ICON_CACHE=ON WITH_IPP=OFF WITH_LIBRARY_VERSIONING=ON WITH_MANPAGES=ON WITH_NEWS=ON WITH_SSE2=ON WITH_TRANSLATIONS=ON WITH_UPDATE_DESKTOP_DB=ON
Build type:          Release
CFLAGS:              -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -Wimplicit-function-declaration -Wredundant-decls
Compiler:            GNU, 11.1.0
Target architecture: x64

• sudo lshw -C video

 *-display                 
       description: VGA compatible controller
       product: UHD Graphics 620 (Whiskey Lake)
       vendor: Intel Corporation
       physical id: 2
       bus info: pci@0000:00:02.0
       version: 02
       width: 64 bits
       clock: 33MHz
       capabilities: pciexpress msi pm vga_controller bus_master cap_list rom
       configuration: driver=i915 latency=0
       resources: irq:187 memory:e9000000-e9ffffff memory:c0000000-cfffffff ioport:2000(size=64) memory:c0000-dffff

• uname -a

5.12.7-arch1-1

Remote System Description

• Server (OS name and version): Arch Linux

• Special notes regarding the remote system (i.e. gateways, tunnel, etc.):

Problem Description

unable to build.

What is the expected correct behavior?

expect Remmina to compile without errors.

Relevant logs and/or screenshots

[ 40%] Building C object plugins/rdp/CMakeFiles/remmina-plugin-rdp.dir/rdp_plugin.c.o
/tmp2/trizen-dag/remmina-git/src/remmina/plugins/rdp/rdp_plugin.c: In function ‘remmina_plugin_entry’:
/tmp2/trizen-dag/remmina-git/src/remmina/plugins/rdp/rdp_plugin.c:2809:40: error: ‘GIT_REVISION’ undeclared (first use in this function); did you mean ‘SID_REVISION’?
 2809 |                  FREERDP_VERSION_FULL, GIT_REVISION,
      |                                        ^~~~~~~~~~~~
      |                                        SID_REVISION
/tmp2/trizen-dag/remmina-git/src/remmina/plugins/rdp/rdp_plugin.c:2809:40: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [plugins/rdp/CMakeFiles/remmina-plugin-rdp.dir/build.make:76: plugins/rdp/CMakeFiles/remmina-plugin-rdp.dir/rdp_plugin.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:538: plugins/rdp/CMakeFiles/remmina-plugin-rdp.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
:: Unable to build remmina-git - makepkg exited with code: 4