Verified Commit b6507800 authored by Adrian DC's avatar Adrian DC
Browse files

feat(gitlab): deprecate '.local: defaults' configurations 

Issue: #292
---

Signed-off-by: default avatarAdrian DC <radian.dc@gmail.com>
parent 0b2a6d6f

README.md

+0 −1
Changes for README.md: 0 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -221,7 +221,6 @@ Supported local values for a `.local` node are: 
.local:

  all: bool              # Enable all jobs by default in selections (see `--all`)

  configurations: dict   # See [User configurations with '.local:configurations'](#user-configurations-with-localconfigurations)

  defaults: bool         # Use default variables for `.local:configurations` (see `--defaults`)

  env: list[str]         # Define `VARIABLE=value`, pass `VARIABLE` or `ENV` file (see `-e`)

  image: dict|str        # Override container image's `name` and/or `entrypoint

  include: dict          # Map `include: project:` names to local paths

docs/deprecations.md

+4 −0
Changes for docs/deprecations.md: 4 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -31,10 +31,14 @@ with inplace project volume mounts and adaptive user selections. 


## Deprecated features



- Since version `13.0.0`, the following `.local:` configurations are removed:

    - `.local: default`: Deprecated and removed, [documented in issue #292](https://gitlab.com/RadianDevCore/tools/gcil/-/issues/292)



- Since version `12.0.0`, the following `.local:` configurations are deprecated:

    - `.local: after`: Use `CI_LOCAL_AFTER` variable globally or per job, [documented in issue #295](https://gitlab.com/RadianDevCore/tools/gcil/-/issues/295)

    - `.local: bash`: Use `CI_LOCAL_BASH` variable globally or per job, [documented in issue #295](https://gitlab.com/RadianDevCore/tools/gcil/-/issues/295)

    - `.local: before`: Use `CI_LOCAL_BEFORE` variable globally or per job, [documented in issue #295](https://gitlab.com/RadianDevCore/tools/gcil/-/issues/295)

    - `.local: default`: Deprecated and pending removal, [documented in issue #292](https://gitlab.com/RadianDevCore/tools/gcil/-/issues/292)

    - `.local: display`: Use `CI_LOCAL_DISPLAY` variable globally or per job, [documented in issue #295](https://gitlab.com/RadianDevCore/tools/gcil/-/issues/295)

    - `.local: engine`: Use `CI_LOCAL_ENGINE` variable globally or per job, [documented in issue #295](https://gitlab.com/RadianDevCore/tools/gcil/-/issues/295)

    - `.local: manual`: Use `CI_LOCAL_MANUAL` variable globally or per job, [documented in issue #295](https://gitlab.com/RadianDevCore/tools/gcil/-/issues/295)

src/parsers/gitlab.py

+0 −5
Changes for src/parsers/gitlab.py: 0 added lines, 5 removed lines.
Original line number Diff line number Diff line
@@ -672,11 +672,6 @@ class GitLab: 
                pipeline.variables.globals[Bundle.FLAG_DEBUG] = Flags.string(

                    local['debug'])



            # Parse local defaults

            if 'defaults' in local and not options.defaults:

                GitLab.__local_deprecation('display', '299')

                options.defaults = local['defaults']



            # Parse local display

            if 'display' in local and not options.display:

                GitLab.__local_deprecation('display', '295')

tests/local/.gitlab-ci.deprecated.yml

+0 −1
Changes for tests/local/.gitlab-ci.deprecated.yml: 0 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ stages: 
        - 'value2'

        - 'value3'

  debug: false

  defaults: true

  display: false

  engine: auto

  manual: false