Verified Commit 8750d609 authored by Adrian DC's avatar Adrian DC
Browse files

fix(main, docker): improve '--rmi' with logs output and help hints 



Signed-off-by: default avatarAdrian DC <radian.dc@gmail.com>
parent afd65592

README.md

+2 −2
Original line number Diff line number Diff line
@@ -145,8 +145,8 @@ features arguments: 
  -d, --dump           # Dump parsed .gitlab-ci.yml configuration

  -s, --select         # Force jobs selection from enumerated names

  -l, --list           # Select one job to run (implies --manual)

  --pull               # Pull container images from all jobs

  --rmi                # Delete container images from all jobs

  --pull               # Pull container images from jobs

  --rmi                # Delete container images from jobs



positional arguments:

  --                   # Positional arguments separator (recommended)

src/cli/main.py

+2 −2
Original line number Diff line number Diff line
@@ -363,13 +363,13 @@ def main() -> None: 
        '--pull',

        dest='pull',

        action='store_true',

        help='Pull container images from all jobs',

        help='Pull container images from jobs',

    )

    subgroup.add_argument(

        '--rmi',

        dest='rmi',

        action='store_true',

        help='Delete container images from all jobs',

        help='Delete container images from jobs',

    )



    # Arguments hidden definitions

src/engines/docker.py

+6 −1
Original line number Diff line number Diff line
@@ -227,8 +227,13 @@ class DockerEngine(BaseEngine): # pragma: docker cover 
        # Remove image

        try:

            self.__client.api.remove_image(image)

            print(f'Untagged: {image}')

        except ImageNotFound:

            pass

            print(f'No such image: {image}')



        # Footer

        print(' ')

        Platform.flush()



    # Run, pylint: disable=too-many-arguments,too-many-positional-arguments

    def run(