Players not redirected to fallback lobby after resource pack rejection if they initially joined in lobby (Velocity)
#### Used Version <!-- The full program version like it is printed in the log --> - ForceResourcepacks version: 1.12.22 #### Config <!-- The full config file --> ```yaml # ForceResourcepacks Velocity config # Unfortunately comments might get removed when the config is edited in the plugin and saved # but you can always find the default config with all comments here: https://l.phoenix616.dev/frpconfigvelocity # --- # Log some stuff about the players packs to the console (pack sending and the status, turn that of on large servers!) debug: true # Default language default-language: zh # Get notified when a new update of the plugin is released # If you only want to allow/block ingame notifications use the # following permission: forceresourcepacks.updatenotification update-notifications: true # Disable all metrics included in this plugin. # If you disabled bStats or PluginMetrics then it will also not send anything :) disable-metrics: false # Whether or not resourcepack file hashes should be generated on startup: autogeneratehashes: true # Whether to append the pack hash to the end of the URL of the pack like url#hash. # This is necessary to work around a Vanilla bug which prevents changed packs from being downloaded # properly again: https://bugs.mojang.com/browse/MC-164316 append-hash-to-url: true # Store joins of players to the disk in order to determinate if this is a first join or not over restarts # Only necessary if you want to use first-join-actions store-joins: true # Time in seconds in which a user needs to respond to the resourcepack prompt # This is needed as users can just ESC out of the prompt # Set to 0 to disable the timeout functionality prompttimeout: 15 # Time in seconds for which a kick is delayed that way you # can display a title or chat message before the kick kickdelay: 0 # Whether /usepack should apply packs temporary or permanent when run without any argument: usepack-is-temporary: true # Whether packs that a player has stored will override a matched assignments stored-packs-override-assignments: false # When manually setting a permanent pack then it will be reset if the user disconnects in under x amount of seconds. # 0 or anything below will disable this functionality permanent-pack-remove-time: 30 # Whether actions require that the plugin sent a pack before or not only-run-actions-after-pack-send: true # Whether to only send packs if authenticated on the Minecraft server # Requires ForceResourcepacks to be installed on the Minecraft server too or nLogin on the proxy use-auth-plugin: false packs: chicken_frenzy: restricted: false permission: pack.chicken_frenzy variants: - url: xxxxx.zip hash: c5abc74219503bec2e1a13333985e30f97a93102 version: "1.21" empty: url: xxxxx.zip hash: 2bf01a06e5f8fabe1e0a679efa0ef0ecf9c37490 global: pack: empty optional-packs: [] send-delay: 0 required: false prompt-message: "&cYou have to accept the server resource pack in order to play!" actions: {} first-join-actions: {} servers: a1: packs: - chicken_frenzy optional-packs: [] prompt-message: "test message" actions: declined: send: lobby message: "&cPlease do not reject resource packages." ``` #### Environment description <!-- Information like the operating system and language as well as full server version if you are using a plugin--> - Velocity version: velocity-3.4.0-SNAPSHOT-503 #### Full Log <!-- The full log file, especially important if you have a stack trace --> ``` [18:59:19] [main/INFO] [com.velocitypowered.proxy.VelocityServer]: Booting up Velocity 3.4.0-SNAPSHOT (git-e13c8c34-b503)... [18:59:19] [main/INFO] [com.velocitypowered.proxy.VelocityServer]: Loading localizations... [18:59:19] [main/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Connections will use NIO channels, Java compression, Java ciphers [18:59:19] [main/INFO] [com.velocitypowered.proxy.VelocityServer]: Loading plugins... [18:59:19] [main/INFO] [com.velocitypowered.proxy.plugin.VelocityPluginManager]: Loaded plugin forceresourcepacks 1.12.22 (build 776) by Phoenix616 [18:59:19] [main/INFO] [com.velocitypowered.proxy.VelocityServer]: Loaded 2 plugins [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loading config! [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loaded config.yml [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loaded players.conf [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Debug level: INFO [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loaded key.yml [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Found locale en [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loading packs: [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: chicken_frenzy - 1 variants [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] {url=null, uuid=null, hash=null, local-path=null, format=null, version=null, restricted=false, permission=toilet.pack.chicken_frenzy, type=null, variants=[{url=xxxxx.zip, uuid=61e2fe0d-297f-3d7b-af17-d29d448646f3, hash=c5abc74219503bec2e1a13333985e30f97a93102, local-path=null, format=null, version=1.21, restricted=false, permission=forceresourcepacks.pack.chicken_frenzy-variant-1, type=null, variants=null}]} [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Empty pack - xxxxx.zip - 2bf01a06e5f8fabe1e0a679efa0ef0ecf9c37490 [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loading global assignment... [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Pack: empty [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Optional packs: [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Send delay: 0 [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Required: false [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Prompt message: &cYou have to accept the server resource pack in order to play! [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Loaded PackActionAssignment{name=global, packs=[empty], optionalPacks=[], sendDelay=0, promptMessage=&cYou have to accept the server resource pack in order to play!} [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loading server assignments... [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loading assignment for server a1... [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Packs: [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] - chicken_frenzy [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Optional packs: [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Prompt message: test message [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: a1 actions: [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] DECLINED - SEND: lobby [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] DECLINED - MESSAGE: &cPlease do not reject resource packages. [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Loaded server assignment PackActionAssignment{name=a1, packs=[chicken_frenzy], optionalPacks=[], sendDelay=-1, promptMessage=test message, statusMap=[=[DECLINED=[SEND=lobby, MESSAGE=&cPlease do not reject resource packages.} [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Stored packs override assignments: false [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: [DEBUG] Append hash to pack URL: true [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Loaded joined.yml [18:59:19] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: Update notifications are enabled! [18:59:20] [Netty NIO Boss #0/INFO] [com.velocitypowered.proxy.network.ConnectionManager]: Listening on /[0:0:0:0:0:0:0:0]:25565 [18:59:20] [main/INFO] [com.velocitypowered.proxy.Velocity]: Done (1.16s)! [18:59:29] [Netty NIO Worker #0/INFO] [com.velocitypowered.proxy.connection.client.AuthSessionHandler]: [connected player] TheLittle_Yang (/127.0.0.1:3513) has connected [18:59:29] [ForceResourcepacks - Task Executor #2/INFO] [forceresourcepacks]: [DEBUG] Player TheLittle_Yang is connecting to server lobby [18:59:29] [Netty NIO Worker #0/INFO] [com.velocitypowered.proxy.connection.MinecraftConnection]: [server connection] TheLittle_Yang -> lobby has connected [18:59:29] [ForceResourcepacks - Task Executor #2/INFO] [forceresourcepacks]: [DEBUG] TheLittle_Yang matched assignment global due to main packs [18:59:30] [ForceResourcepacks - Task Executor #2/INFO] [forceresourcepacks]: [DEBUG] TheLittle_Yang matched assignment global due to main packs [18:59:33] [ForceResourcepacks - Task Executor #2/INFO] [forceresourcepacks]: [DEBUG] Player TheLittle_Yang is connecting to server a1 [18:59:33] [Netty NIO Worker #0/INFO] [com.velocitypowered.proxy.connection.MinecraftConnection]: [server connection] TheLittle_Yang -> a1 has connected [18:59:34] [Netty NIO Worker #0/INFO] [com.velocitypowered.proxy.connection.MinecraftConnection]: [server connection] TheLittle_Yang -> lobby has disconnected [18:59:34] [ForceResourcepacks - Task Executor #2/INFO] [forceresourcepacks]: [DEBUG] TheLittle_Yang matched assignment a1 due to main packs variant [18:59:34] [ForceResourcepacks - Task Executor #3/INFO] [forceresourcepacks]: TheLittle_Yang: running actions for pack chicken_frenzy and status 11/REQUESTED/first join: false [18:59:34] [ForceResourcepacks - Task Executor #2/INFO] [forceresourcepacks]: [DEBUG] Sent pack chicken_frenzy-variant-1 (xxxxx.zip) to TheLittle_Yang. Required: false, Prompt message: test message [18:59:35] [ForceResourcepacks - Task Executor #0/INFO] [forceresourcepacks]: TheLittle_Yang: running actions for pack chicken_frenzy and status 1/DECLINED/first join: false [18:59:35] [ForceResourcepacks - Task Executor #2/INFO] [forceresourcepacks]: [DEBUG] Allowing Configuration phase even through we failed to send all packs to TheLittle_Yang [18:59:35] [ForceResourcepacks - Task Executor #2/INFO] [forceresourcepacks]: [DEBUG] Failed to send pack 61e2fe0d-297f-3d7b-af17-d29d448646f3 to TheLittle_Yang ``` #### What other programs/plugins are you running? <!-- List of your plugins, ideally with the version or other programs that might be related --> There are no other plugins. #### What is happening? <!-- Explain what happens and what steps should be done to reproduce the issue. Ideally with pictures and the full error log! --> When a player starts in the `lobby` server and uses `/server a1` to join another server, if they reject the resource pack, the plugin tries to redirect them back to the fallback (`lobby`). However, since they originally joined in `lobby`, this redirection fails and the player is stuck on the `a1` server, receiving the error message: ``` You are already trying to connect to a server! ``` #### What did you expect to happen? <!-- Explain what you expected to happen after performing the previously described steps --> Even if the player initially joined on the fallback server, they should still be successfully redirected back to it after rejecting the resource pack. They should not be stuck on the target server (`a1`). #### Additional context <!-- Add any other context or screenshots about the bug report here. --> none
issue