Need better error logging for Resource.Open

When a resource throws an exception during Open, the error logging is not great. The issues are:

1. Any relevant error message and stack trace is buried irrelevant info
2. The name of the resource which threw the exception is never stated.

created merge request !754 (merged) to address this issue

mentioned in merge request !754 (merged)

changed the description

Hi @david-wsd, thanks for submitting an issue.

I agree in this case the exception message is unhelpful. We should probably be more careful when doing exception messages.

Regarding the part you dont know how to eleminate, it is something we added recently to better be able to pinpoint the location where the exception was caught. Is systems become more complex, this can be useful information as well. That being said, we probably don't have to print the entire thing. Maybe we could settle to just printing the top of the stack?

If you don't mind, I can add it to your MR.

changed milestone to %9.13

added Feature label

Thanks @romadsen-ks. Understood about the lower messages / stack trace. Maybe it's useful info with other UIs, or other scenarios. At least it's printed at the bottom, so it's not as distracting as the messages at the top. Printing a portion of it is a good idea, if that suffices for everyone else. Feel free to add to the MR.

@david-wsd, Great, I'll look into this for 9.13. Hope that timeframe is OK.

assigned to @romadsen-ks

added flow::Merge Requested label

closed with merge request !754 (merged)

mentioned in commit 905211c0

Implemented. Verified on OpenTAP.9.13.0-beta.16

Before:

After:

added QA Verified label

Hi @sebastian.vlaic, will the name of the resource be included in the error log?

@david-wsd currently the name of the resource is not included. @romadsen-ks what do you think ?

We should include the name of the resource.

mentioned in merge request !845 (merged)