Unverified Commit 7bbf0b52 authored by Bret Curtis's avatar Bret Curtis Committed by GitHub

Merge pull request #2253 from elsid/fix_navmesh_tiles_cache_ub

Do not pass nullptr to std::memcmp
parents 7917f1fc dd0b45ed
Pipeline #51925367 passed with stage
......@@ -179,6 +179,17 @@ namespace DetourNavigator
const auto lhsEnd = reinterpret_cast<const char*>(lhs.data() + lhs.size());
const auto lhsSize = static_cast<std::ptrdiff_t>(lhsEnd - lhsBegin);
const auto rhsSize = static_cast<std::ptrdiff_t>(mRhsEnd - mRhsIt);
if (lhsBegin == nullptr || mRhsIt == nullptr)
{
if (lhsSize < rhsSize)
return -1;
else if (lhsSize > rhsSize)
return 1;
else
return 0;
}
const auto size = std::min(lhsSize, rhsSize);
if (const auto result = std::memcmp(lhsBegin, mRhsIt, size))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment