Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • openmw openmw
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 756
    • Issues 756
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenMWOpenMW
  • openmwopenmw
  • Merge requests
  • !1821

Tell CMake where to find ICU properly

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged AnyOldName3 requested to merge AnyOldName3/openmw:now-you-see-me into master May 02, 2022
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

I had a problem where CMake picked up half of ICU from its C API, which is included with the Windows SDK, and half from the C++ API we provide. This should prevent that.

  • ICU_ROOT takes precedence as a CMake variable so do that instead of as an environment variable.
  • ICU_LIBRARY is an output of FindICU.cmake, not an input, so don't set it.
  • FindICU.cmake needs telling about components via their own variables.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: now-you-see-me