Skip to content

Follow-up from "Add and fix -Wshadow" - some warnings we nominally have enabled still aren't working with MSVC

The following discussion from !4859 (merged) should be addressed:

  • @AnyOldName3 started a discussion: (+6 comments)

    C4456 and C4457 should cover this with MSVC and be implied by /W4, which we use, so I don't understand how we can have -Wshadow triggering unless there's yet another problem with warnings and MSVC that we need to fix.