Follow-up from "Add notification handler to worker subscription"
The following discussions from !5105 (merged) should be addressed:
-
@DavidVorick started a discussion: need to make an issue if one doesn't exist yet
-
@DavidVorick started a discussion: need to make an issue if one doesn't exist yet
-
@DavidVorick started a discussion: cooldown f/u
-
@DavidVorick started a discussion: cooldown f/u
-
@DavidVorick started a discussion: (+2 comments) do we need to close some channel here or otherwise inform a listener (like the API) that there's been an update?
-
@pjbrone started a discussion: (nit) no need for
Errorf
-
@pjbrone started a discussion: // host sent this notification either without us requesting it or
-
@pjbrone started a discussion: w.renter.log.Print("managedHandleNotification: failed to set deadline on stream: ", err)
-
@pjbrone started a discussion: should we at least log something in this case?
-
@pjbrone started a discussion: // buffered so this doesn't block. Also fetch the handler's