Follow-up from "Partial snapshots for non stream downloads and repair downloads"
The following discussions from !4911 (merged) should be addressed:
-
@DavidVorick started a discussion: f/u: feels clunky that it still returns a []chunk with the len of the whole file. If we're going to return a subset, we should probably only return exactly the chunks that we want.
-
@ro-tex started a discussion: I was surprised that the code actually returns all chunks in the siafile and only has data for the chunks in the range. Reading the docstring I expected the chunks outside the
[min;max]
range to not be included at all. -
@DavidVorick started a discussion: f/u: should we be using maxint64 here? Should we switch the input from being an
int
to anint64
? Or even auint64
?