Follow-up from "Handle special chars in paths when running skylink GET"
The following discussions from !4790 (merged) should be addressed:
-
@m-cat started a discussion: f/u: This comment is a bit confusing, I'll rewrite it to something like:
Parse the skylink from the raw URL of the request. Any special characters in this URL are still encoded, allowing us to differentiate e.g. the '?' that begins query parameters from the encoded version '%3F'.
-
@ro-tex started a discussion: F/U: This is a very interesting case that is entirely valid and a little obscure as well. It might be nice to add an explicit explanation somewhere in the documentation. I'm not sure which would be the bast place but some clarification that the unencoded query params are for us to parse and use and the encoded ones are for the skapp would be nice.
-
@ro-tex started a discussion: super-nit: It's not important if you're not using it in the tests but adding a new file changes the total length of the data and should be reflected on line 70. I don't think we need to change that in this case but it's good to keep the test data super consistent unless we're using the inconsistency for testing.