Follow-up from "Add profile start/stop to the API"
The following discussions from !4780 (merged) should be addressed:
-
@m-cat started a discussion: Long: "Start and stop CPU, memory, and/or trace profiles for the daemon",
-
@m-cat started a discussion: Should state what each of
cmt
stands for. Also, is it possible to make these flags? That would be more standard, as well as simplify the validation. Cobra should let you combine the flags, i.e. user could pass either-c -m -t
or just-cmt
, most Unix applications support this. -
@m-cat started a discussion: nit: can we delete this line?
-
@m-cat started a discussion: nit: Should we do validation of the profile here, while getting these values? Instead it seems like
startDaemonCmd
callsstartDaemon
which callsprocessConfig
which does the validation. -
@DavidVorick started a discussion: spaces are a problem? Not sure I agree that this should be an error case