Follow-up from "Have siadir metadata update create the full path if it doesn't exist"
The following discussions from !4694 (merged) should be addressed:
-
@MSevey started a discussion: Added TODO for follow up issue.
-
@MSevey started a discussion: this was ultimately the cause of the panic. This function removes the directory on disk and that was why we were getting the panic for the file not found.
The other updates in this MR are still valid I think and worth merging in.
-
@pjbrone started a discussion: (+1 comment) I believe you're adding the
rt.dir
twice here -
@pjbrone started a discussion: (+1 comment) I believe you're adding the
rt.dir
twice here -
@pjbrone started a discussion: (+1 comment) (nit) you could add a case where you try to update the metadata of a dir. for which you've physically removed it on disk, testing the
build.Critical
onif os.IsNotExist(err) {