Follow-up from "Start using WAL"
The following discussions from !4229 (merged) should be addressed:
-
@ChrisSchinnerl started a discussion: (+5 comments) Can you also run
make cover
to see if we got reasonable unit test coverage? -
@ChrisSchinnerl started a discussion: FU: This can be a standalone test with
t.Parallel
in the beginning to speed things up a bit. -
@ChrisSchinnerl started a discussion: Can also be a standalone test
-
@ChrisSchinnerl started a discussion: FU: add
t.Parallel()
-
@ChrisSchinnerl started a discussion: Just a note for the future.
When writing unit tests you don't need to test the functionality of the whole type within a single function. It's fine to have individual tests for every method on the refcounters and a few more complex tests which combine methods for more complex edge cases. That makes things more readable and potentially faster as long as you add
t.Parallel
to the tests.
Related to #3836