Follow-up from "Add adequate fund/collateral check to revision creation."
The following discussion from !4211 (merged) should be addressed:
-
@ro-tex started a discussion: (+1 comment) This LGTM, although I don't have a good grasp of the context, so if there's anything missing I won't be able to tell.
I did some head-scratching around the work with
NewValidProofOutputs[<idx>]
- it seems that index 0 is the host, 1 is the renter and 2 is void. What do you guys think about moving those to named constants in order to make the reading a little easier? (Not in this MR, of course.)