Follow-up from "Combine SiaDirSet and SiaFileSet within FileSystem"
The following discussions from !3877 (merged) should be addressed:
-
Incomplete test coverage -
@MSevey started a discussion: @ChrisSchinnerl once !3923 (merged) is merge it would be nice to run the full code coverage tool for this branch to see how well the new code is covered.
-
@DavidVorick started a discussion: (+2 comments) Maybe for a follow-up, we'll have to decide what folders all get put into the tar. It'll probably end up being more than just the user's home (for example, if we have application data in /apps, we might want to carry those files along as well)
-
@DavidVorick started a discussion: (+4 comments) Do we want to rebase here? What does the alert show if the file in question is not a user file? How does the user distinguish between a userfile that's at low redundancy vs. a system file that's at low redundancy?
-
@DavidVorick started a discussion: (+4 comments) does this err need to be checked?
-
@DavidVorick started a discussion: (+2 comments) this name is confusing and I'm not sure what a better name might be.
-
@DavidVorick started a discussion: Looks like this is a leftover from a bad merge
-
@DavidVorick started a discussion: would like to see this switched into the same format as in the Makefile
-
@DavidVorick started a discussion: would like to see this switched into the same format as in the Makefile