warnings in xcode 7.3 on osx 10.11.4
xcode 7.3 static analyzer added more checks and found these warnings:
$ ./waf distclean && ./waf configure && ./waf build
'distclean' finished successfully (0.041s)
Setting top to : /Users/selsky/src/gitlab.com/ntpsec
Setting out to : /Users/selsky/src/gitlab.com/ntpsec/build
--- Configuring host ---
Checking for 'clang' (C compiler) : /usr/bin/clang
Checking for program 'bison' : /usr/bin/bison
Checking compiler : yes
Compiler found : clang
Checking for program 'awk' : /usr/bin/awk
Checking for program 'perl' : /usr/bin/perl
Checking for program 'sh' : /bin/sh
Checking for program 'asciidoc' : not found
Checking for program 'a2x' : not found
Checking for program 'xsltproc' : /usr/bin/xsltproc
Checking for program 'git' : /usr/local/bin/git
DEVEL: Getting revision : efbfbb331d7c406c3b4c7d830e4a5d797bbbc97c
Building version : 0.9.3-efbfbb3
--- Configuring main ---
Checking build target : osx
Checking for type uint64_t : yes
Checking for type struct if_laddrconf : no
Checking for type struct if_laddrreq : no
Checking for type struct timex : no
Checking for type struct ntptimeval : no
Checking for time_tick in struct timex : no
Checking for modes in struct timex : no
Checking for time.tv_nsec in struct ntptimeval : no
Checking sizeof int : 4
Checking sizeof long : 8
Checking sizeof long long : 8
Checking sizeof time_t (time.h) : 8
Checking for multicast capability : yes
Checking for library edit : yes
Checking for library m : yes
Checking for library ossaudio : not found
Checking for library pthread : yes
Checking for library rt : not found
Checking for library curses : yes
Checking for library readline : yes
Checking for library thr : not found
Checking for library gcc_s : not found
Checking for function adjtimex : no
Checking for function closefrom : no
Checking for function clock_gettime : no
Checking for function clock_settime : no
Checking for function EVP_MD_do_all_sorted : no
Checking for function getclock : no
Checking for function getpassphrase : no
Checking for function MD5Init : no
Checking for function ntp_adjtime : no
Checking for function ntp_gettime : no
Checking for function res_init : no
Checking for function rtprio : no
Checking for function sched_setscheduler : no
Checking for function settimeofday : yes
Checking for function strlcpy : yes
Checking for function strlcat : yes
Checking for function timer_create : no
Checking for header stdbool.h : yes
Checking for header dns_sd.h : yes
Checking for header histedit.h : yes
Checking for header ifaddrs.h : yes
Checking for header libscf.h : not found
Checking for header linux/if_addr.h : not found
Checking for header linux/rtnetlink.h : not found
Checking for header linux/serial.h : not found
Checking for header machine/soundcard.h : not found
Checking for header md5.h : no
Checking for header net/if6.h : not found
Checking for header net/route.h : yes
Checking for header netinfo/ni.h : not found
Checking for header priv.h : not found
Checking for header readline/readline.h : yes
Checking for header readline/history.h : yes
Checking for header resolv.h : yes
Checking for header semaphore.h : yes
Checking for header stdatomic.h : yes
Checking for header sys/audioio.h : not found
Checking for header sys/capability.h : not found
Checking for header sys/ioctl.h : yes
Checking for header sys/modem.h : not found
Checking for header sys/prctl.h : not found
Checking for header sys/sockio.h : yes
Checking for header sys/soundcard.h : not found
Checking for header sys/sysctl.h : yes
Checking for header timepps.h : no
Checking for header sys/timepps.h : no
Checking for header utmpx.h : yes
Checking for header sys/timex.h : no
Checking for header sys/audio.h : not found
Checking for type sockaddr_storage : yes
Checking for sockaddr->sa_len : yes
Checking for %m expansion in vsnprintf(3) : no
Checking for header sys/capability.h : not found
Checking for library cap : not found
Checking for header event2/event.h : yes
Checking for header event2/thread.h : yes
Checking for library event_core : yes
Checking for library event_pthreads : yes
Checking for library dns_sd : not found
Checking for header dns_sd.h : yes
Checking if libcap works : no
Checking if libevent2 works : yes
Checking if mDNSResponder works : yes
Writing configuration header: : config.h
Build Options
CC : /usr/bin/clang
CFLAGS : -Wall -Wextra
LDFLAGS :
PREFIX : /usr/local
Debug Support : Yes
Refclocks :
Build Manpages : No
'configure' finished successfully (4.650s)
--- building host ---
Waf: Entering directory `/Users/selsky/src/gitlab.com/ntpsec/build/host'
[1/5] Processing ntpd/ntp_parser.y
[2/5] Compiling build/host/ntpd/ntp_parser.tab.c
[3/5] Compiling ntpd/keyword-gen.c
[4/5] Linking build/host/ntpd/keyword-gen
[5/5] Compiling build/host/ntpd/ntp_parser.tab.h
181 keywords consumed 854 states of 2047 max.
Waf: Leaving directory `/Users/selsky/src/gitlab.com/ntpsec/build/host'
--- building main ---
Waf: Entering directory `/Users/selsky/src/gitlab.com/ntpsec/build/main'
[ 1/181] Compiling libisc/assertions.c
[ 2/181] Compiling libisc/backtrace-emptytbl.c
[ 3/181] Compiling libisc/backtrace.c
[ 4/181] Compiling libisc/error.c
[ 5/181] Compiling libisc/md5.c
[ 6/181] Compiling libisc/netaddr.c
[ 7/181] Compiling libisc/result.c
[ 8/181] Compiling libisc/sha1.c
[ 9/181] Compiling libisc/unix/errno2result.c
[ 10/181] Compiling libisc/unix/interfaceiter.c
[ 11/181] Compiling libisc/unix/net.c
[ 12/181] Compiling libntp/a_md5encrypt.c
[ 13/181] Compiling libntp/atolfp.c
[ 14/181] Compiling libntp/authkeys.c
[ 15/181] Compiling libntp/authreadkeys.c
[ 16/181] Compiling libntp/authusekey.c
[ 17/181] Compiling libntp/caljulian.c
[ 18/181] Compiling libntp/caltontp.c
[ 19/181] Compiling libntp/calyearstart.c
[ 20/181] Compiling libntp/clocktime.c
[ 21/181] Compiling libntp/clocktypes.c
[ 22/181] Compiling libntp/decodenetnum.c
[ 23/181] Compiling libntp/dofptoa.c
[ 24/181] Compiling libntp/dolfptoa.c
[ 25/181] Compiling libntp/emalloc.c
[ 26/181] Compiling libntp/getopt.c
[ 27/181] Compiling libntp/hextolfp.c
[ 28/181] Compiling libntp/humandate.c
[ 29/181] Compiling libntp/icom.c
[ 30/181] Compiling libntp/iosignal.c
[ 31/181] Compiling libntp/lib_strbuf.c
[ 32/181] Compiling libntp/machines.c
[ 33/181] Compiling libntp/modetoa.c
[ 34/181] Compiling libntp/mstolfp.c
[ 35/181] Compiling libntp/msyslog.c
[ 36/181] Compiling libntp/netof.c
[ 37/181] Compiling libntp/ntp_calendar.c
[ 38/181] Compiling libntp/ntp_intres.c
[ 39/181] Compiling libntp/ntp_lineedit.c
[ 40/181] Compiling libntp/ntp_random.c
[ 41/181] Compiling libntp/ntp_rfc2553.c
[ 42/181] Compiling libntp/ntp_worker.c
[ 43/181] Compiling libntp/numtoa.c
[ 44/181] Compiling libntp/numtohost.c
[ 45/181] Compiling libntp/prettydate.c
[ 46/181] Compiling libntp/recvbuff.c
[ 47/181] Compiling libntp/refnumtoa.c
[ 48/181] Compiling libntp/refidsmear.c
[ 49/181] Compiling libntp/socket.c
[ 50/181] Compiling libntp/socktoa.c
[ 51/181] Compiling libntp/socktohost.c
[ 52/181] Compiling libntp/ssl_init.c
[ 53/181] Compiling libntp/statestr.c
[ 54/181] Compiling libntp/strl_obsd.c
[ 55/181] Compiling libntp/syssignal.c
[ 56/181] Compiling libntp/timetoa.c
[ 57/181] Compiling libntp/timevalops.c
[ 58/181] Compiling libntp/vint64ops.c
[ 59/181] Compiling libntp/work_thread.c
[ 60/181] Compiling libntp/ymd2yd.c
[ 61/181] Compiling libntp/systime.c
[ 62/181] Compiling ntpdig/crypto.c
[ 63/181] Compiling ntpdig/kod_management.c
../../libntp/systime.c:460:37: warning: variable 'tvlast' is uninitialized when used here [-Wuninitialized]
tvdiff = abs_tval(sub_tval(timetv, tvlast));
^~~~~~
../../libntp/systime.c:360:2: note: variable 'tvlast' is declared here
struct timeval timetv, tvlast, tvdiff;
^
1 warning generated.
[ 64/181] Compiling ntpdig/log.c
[ 65/181] Compiling ntpdig/main.c
[ 66/181] Compiling ntpdig/networking.c
[ 67/181] Compiling ntpdig/utilities.c
[ 68/181] Creating build/main/ntpdig/version.c
[ 69/181] Compiling ntpdig/ntpdig.c
[ 70/181] Compiling build/main/ntpdig/version.c
[ 71/181] Compiling libsodium/sodium/core.c
[ 72/181] Compiling libsodium/randombytes/randombytes.c
[ 73/181] Compiling libsodium/randombytes/sysrandom/randombytes_sysrandom.c
[ 74/181] Compiling ntpd/ntp_control.c
[ 75/181] Compiling ntpd/ntp_crypto.c
[ 76/181] Compiling ntpd/ntp_filegen.c
[ 77/181] Compiling ntpd/ntp_intercept.c
[ 78/181] Compiling ntpd/ntp_leapsec.c
[ 79/181] Compiling ntpd/ntp_loopfilter.c
[ 80/181] Compiling ntpd/ntp_monitor.c
[ 81/181] Compiling ntpd/ntp_peer.c
[ 82/181] Compiling ntpd/ntp_proto.c
[ 83/181] Compiling ntpd/ntp_restrict.c
[ 84/181] Compiling ntpd/ntp_sandbox.c
[ 85/181] Compiling ntpd/ntp_signd.c
[ 86/181] Compiling ntpd/ntp_timer.c
[ 87/181] Compiling ntpd/ntp_util.c
[ 88/181] Creating build/main/ntpd/version.c
[ 89/181] Compiling ntpd/ntp_config.c
[ 90/181] Compiling ntpd/ntp_io.c
[ 91/181] Compiling ntpd/ntp_scanner.c
[ 92/181] Compiling ntpd/ntpd.c
[ 93/181] Compiling build/host/ntpd/ntp_parser.tab.c
[ 94/181] Compiling build/main/ntpd/version.c
[ 95/181] Compiling ntpfrob/main.c
[ 96/181] Compiling ntpfrob/jitter.c
[ 97/181] Compiling ntpfrob/precision.c
[ 98/181] Compiling ntpfrob/pps-api.c
[ 99/181] Compiling ntpfrob/tickadj.c
[100/181] Compiling ntpq/libntpq.c
[101/181] Compiling ntpq/libntpq_subs.c
[102/181] Creating build/main/ntpq/version.c
[103/181] Compiling ntpq/ntpq.c
[104/181] Compiling ntpq/ntpq-subs.c
[105/181] Compiling ntpkeygen/ntpkeygen.c
[106/181] Compiling util/bumpclock.c
[107/181] Compiling util/hist.c
[108/181] Compiling util/propdelay.c
[109/181] Compiling util/sht.c
[110/181] Compiling tests/unity/unity.c
[111/181] Compiling tests/unity/unity_fixture.c
[112/181] Compiling tests/ntpdig/crypto.c
[113/181] Compiling tests/ntpdig/key_file.c
[114/181] Compiling tests/ntpdig/kod_database.c
[115/181] Compiling tests/ntpdig/kod_file.c
[116/181] Compiling tests/ntpdig/packet_handling.c
[117/181] Compiling tests/ntpdig/packet_processing.c
[118/181] Compiling tests/ntpdig/utilities.c
[119/181] Compiling tests/common/tests_main.c
[120/181] Compiling tests/common/caltime.c
[121/181] Compiling tests/common/sockaddrtest.c
[122/181] Compiling tests/common/file_handling.c
[123/181] Compiling tests/libntp/a_md5encrypt.c
[124/181] Compiling tests/libntp/authkeys.c
[125/181] Compiling tests/libntp/calendar.c
[126/181] Compiling tests/libntp/caljulian.c
[127/181] Compiling tests/libntp/caltontp.c
[128/181] Compiling tests/libntp/calyearstart.c
[129/181] Compiling tests/libntp/clocktime.c
[130/181] Compiling tests/libntp/decodenetnum.c
[131/181] Compiling tests/libntp/hextolfp.c
[132/181] Compiling tests/libntp/humandate.c
[133/181] Compiling tests/libntp/lfptostr.c
[134/181] Compiling tests/libntp/modetoa.c
[135/181] Compiling tests/libntp/msyslog.c
[136/181] Compiling tests/libntp/netof.c
[137/181] Compiling tests/libntp/numtoa.c
[138/181] Compiling tests/libntp/numtohost.c
[139/181] Compiling tests/libntp/prettydate.c
[140/181] Compiling tests/libntp/recvbuff.c
[141/181] Compiling tests/libntp/sfptostr.c
[142/181] Compiling tests/libntp/socktoa.c
[143/181] Compiling tests/libntp/ssl_init.c
../../tests/libntp/sfptostr.c:31:19: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
s_fp test = -200 << 16; // exact -200.000000
~~~~ ^
../../tests/libntp/sfptostr.c:45:20: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
s_fp test = (-200 << 16) - (1 << 15); // -200 - 0.5
~~~~ ^
../../tests/libntp/sfptostr.c:59:20: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
s_fp test = (-200 << 16) + (1 << 14)*3; // -200 + 0.75
~~~~ ^
3 warnings generated.
[144/181] Compiling tests/libntp/statestr.c
[145/181] Compiling tests/libntp/strtolfp.c
[146/181] Compiling tests/libntp/tstotv.c
[147/181] Compiling tests/libntp/tvtots.c
[148/181] Compiling tests/libntp/vi64ops.c
[149/181] Compiling tests/libntp/ymd2yd.c
[150/181] Compiling tests/common/tests_main.c
[151/181] Compiling tests/common/caltime.c
[152/181] Compiling tests/common/sockaddrtest.c
[153/181] Compiling tests/common/file_handling.c
[154/181] Compiling tests/ntpd/leapsec.c
[155/181] Compiling tests/common/tests_main.c
[156/181] Compiling tests/common/caltime.c
[157/181] Compiling tests/common/sockaddrtest.c
[158/181] Compiling tests/common/file_handling.c
[159/181] Compiling ntpwait/ntpwait
[160/181] Compiling ntptrace/ntptrace
[161/181] Compiling util/ntpsweep/ntpsweep
[162/181] Linking build/main/libsodium/libsodium.a
[163/181] Linking build/main/libisc/libisc.a
[164/181] Linking build/main/ntpd/libntpd_lib.a
[165/181] Compiling build/main/ntpq/version.c
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ntpd/libntpd_lib.a(ntp_signd.c.1.o) has no symbols
[166/181] Linking build/main/libntp/libntp.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libntp/libntp.a(strl_obsd.c.1.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libntp/libntp.a(timevalops.c.1.o) has no symbols
[167/181] Linking build/main/ntpdig/ntpdig
[170/181] Linking build/main/tests/test_ntpdig
[170/181] Linking build/main/util/propdelay
[170/181] Linking build/main/tests/test_libntp
[171/181] Linking build/main/util/bumpclock
[172/181] Linking build/main/util/sht
[173/181] Linking build/main/ntpkeygen/ntpkeygen
[174/181] Linking build/main/ntpfrob/ntpfrob
[175/181] Linking build/main/ntpd/ntpd
[176/181] Linking build/main/ntpq/ntpq
[177/181] Linking build/main/util/hist
[178/181] Processing build/main/tests/test_ntpdig
[180/181] Processing build/main/tests/test_libntp
[180/181] Linking build/main/tests/test_ntpd
[181/181] Processing build/main/tests/test_ntpd
Waf: Leaving directory `/Users/selsky/src/gitlab.com/ntpsec/build/main'
Wrote test log to: /Users/selsky/src/gitlab.com/ntpsec/build/main/test.log
execution summary
tests that pass 3/3
/Users/selsky/src/gitlab.com/ntpsec/build/main/tests/test_ntpdig
/Users/selsky/src/gitlab.com/ntpsec/build/main/tests/test_ntpd
/Users/selsky/src/gitlab.com/ntpsec/build/main/tests/test_libntp
tests that fail 0/3
'build' finished successfully (7.485s)