on malformed nts maxtls or mintls in config segfault ensues
Expected behavior is that ntpd should issue a warning. Actual behavior is that it segfaults.
Steps to recreate
- put the line
nts mintls 1.2ornts maxtls 1.2in the NTPsec config file - start ntpd
> sudo ntpsec/build/main/ntpd/ntpd -Nn -D3
2019-03-02T10:43:04 ntpd[191200]: INIT: ntpd ntpsec-1.1.3+ 2019-03-02T17:12:21Z (git rev aded4d954): Starting
2019-03-02T10:43:04 ntpd[191200]: INIT: Command line: ntpsec/build/main/ntpd/ntpd -Nn -D3
2019-03-02T10:43:04 ntpd[191200]: INIT: set_process_priority: Attempt to set priority
2019-03-02T10:43:04 ntpd[191200]: INIT: precision = 0.154 usec (-23)
2019-03-02T10:43:04 ntpd[191200]: INIT: successfully locked into RAM
2019-03-02T10:43:04 ntpd[191200]: CONFIG: readconfig: parsing file: /etc/ntp.conf
2019-03-02T10:43:04 ntpd[191200]: CONFIG: readconfig: parsing directory: /etc/ntp.conf
Finished Parsing!!
configuring filegen:
dir: /var/NTP/ -> /var/log/ntpstats/
fname: clockstats -> clockstats
type: 2 -> 2
flag: 1 -> 1
configuring filegen:
dir: /var/NTP/ -> /var/log/ntpstats/
fname: loopstats -> loopstats
type: 2 -> 2
flag: 1 -> 1
configuring filegen:
dir: /var/NTP/ -> /var/log/ntpstats/
fname: rawstats -> rawstats
type: 2 -> 2
flag: 1 -> 1
configuring filegen:
dir: /var/NTP/ -> /var/log/ntpstats/
fname: sysstats -> sysstats
type: 2 -> 2
flag: 1 -> 1
configuring filegen:
dir: /var/NTP/ -> /var/log/ntpstats/
fname: peerstats -> peerstats
type: 2 -> 2
flag: 1 -> 1
configuring filegen:
dir: /var/NTP/ -> /var/log/ntpstats/
fname: protostats -> protostats
type: 2 -> 2
flag: 1 -> 1
configuring filegen:
dir: /var/NTP/ -> /var/log/ntpstats/
fname: usestats -> usestats
type: 2 -> 2
flag: 1 -> 1
configuring filegen:
dir: /var/log/ntpstats/ -> /var/log/ntpstats/
fname: loopstats -> loopstats
type: 2 -> 2
flag: 1 -> 81
configuring filegen:
dir: /var/log/ntpstats/ -> /var/log/ntpstats/
fname: peerstats -> peerstats
type: 2 -> 2
flag: 1 -> 81
getnetnum given ::, got ::
getnetnum given ::, got ::
restrict: op 1 addr :: mask :: mflags 00000000 flags 000004a0
restrict: op 1 addr 0.0.0.0 mask 0.0.0.0 mflags 00000000 flags 000004a0
restrict: op 1 addr :: mask :: mflags 00000000 flags 000004a0
getnetnum given 127.0.0.1, got 127.0.0.1
restrict: op 1 addr 127.0.0.1 mask 255.255.255.255 mflags 00000000 flags 00000000
getnetnum given 192.168.42.0, got 192.168.42.0
getnetnum given 255.255.255.0, got 255.255.255.0
restrict: op 1 addr 192.168.42.0 mask 255.255.255.0 mflags 00000000 flags 00000000
getnetnum given ::1, got ::1
restrict: op 1 addr ::1 mask ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff mflags 00000000 flags 00000000
getnetnum given fe80::, got fe80::
restrict: op 1 addr fe80:: mask ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff mflags 00000000 flags 00000000
restrict: op 1 addr 0.0.0.0 mask 0.0.0.0 mflags 00000000 flags 000004f0
restrict: op 1 addr :: mask :: mflags 00000000 flags 000004f0
getnetnum given ::, got ::
getnetnum given ::, got ::
restrict: op 1 addr :: mask :: mflags 00000000 flags 000004f0
getnetnum given 127.0.0.1, got 127.0.0.1
restrict: op 1 addr 127.0.0.1 mask 255.255.255.255 mflags 00000000 flags 00000000
getnetnum given ::1, got ::1
restrict: op 1 addr ::1 mask ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff mflags 00000000 flags 00000000
[1] 191199 segmentation fault sudo ntpsec/build/main/ntpd/ntpd -Nn -D3
>