• Nathan Harris's avatar
    Remove unnecessary assertions in `RedisCommandHandler` · ba66ebf8
    Nathan Harris authored
    Motivation:
    
    The assertions in `errorCaught(context:error:)` and `channelRead(context:data:)` are holdovers from when SwiftLog was not integrated into the package. The conditions where they were triggered are safely handled in other ways, so the asserts are not guarding against undefined behavior or bad app state.
    
    Modifications:
    
    Remove the two asserts regarding the `RedisCommandHandler.commandResponseQueue` to rely on Logging to bubble up errors to the user.
    
    Result:
    
    Debug builds using RediStack should not encounter unexpected assertions and should rely on other, better, error handling.
    
    This contributes to issue #65
    ba66ebf8
Name
Last commit
Last update
Sources Loading commit data...
Tests Loading commit data...
docs/theme Loading commit data...
scripts Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
.mailmap Loading commit data...
CHANGELOG.md Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.txt Loading commit data...
LICENSE.txt Loading commit data...
NOTICE.txt Loading commit data...
Package.swift Loading commit data...
README.md Loading commit data...