1. 25 Jun, 2019 2 commits
  2. 22 Jun, 2019 6 commits
  3. 12 Jun, 2019 2 commits
    • Nathan Harris's avatar
      Merge branch 'add-port-static' into 'master' · 531a7d40
      Nathan Harris authored
      Add static property for default RedisConnection port
      
      See merge request Mordil/swift-redis-nio-client!51
      531a7d40
    • Nathan Harris's avatar
      Add static property for default RedisConnection port · 73b3f5df
      Nathan Harris authored
      Motivation:
      
      The default port for Redis is well published to be 6379, and it is common to want to pass this value around or use it as a static default value in methods and initializers.
      
      Modifications:
      
      Add `RedisConnection.defaultPort` static property for all users to use, and update references of the `6379` literals to use new  the new property.
      
      Result:
      
      Users should have a reliable default defined to use everywhere to avoid bugs.
      73b3f5df
  4. 11 Jun, 2019 4 commits
    • Nathan Harris's avatar
      Merge branch 'fix-data-conversion' into 'master' · 30733dea
      Nathan Harris authored
      Fix `Data` Conversion to `RESPValue`
      
      See merge request Mordil/swift-redis-nio-client!50
      30733dea
    • Nathan Harris's avatar
      Fix `Data` Conversion to `RESPValue` · 34647e14
      Nathan Harris authored
      Motivation:
      
      `Foundation.Data` was unexpectedly receiving `RESPValueConvertible` conformance through the `Collection` extension which lead to incorrect encoding.
      
      Modifications:
      
      Add explicit conformance to `RESPValueConvertible` for `Data`.
      
      Result:
      
      Users should see their `Data` encoding to RESP format as expected.
      34647e14
    • Nathan Harris's avatar
    • Nathan Harris's avatar
      Improve debugging of `RESPValue` · d4584924
      Nathan Harris authored
      Motivation:
      
      Reading output from `RESPValue` existentials is entirely verbose and does not provide a human-readable description of what is being represented.
      
      Modifications:
      
      - Add conformance to `CustomStringConvertible` for `RESPValue`
      - Remove redundant logging of arguments in `RedisConnection.send`
      
      Result:
      
      String representations of `RESPValue` should now be more readable for human to understand.
      d4584924
  5. 07 Jun, 2019 5 commits
    • Nathan Harris's avatar
      Merge branch 'docs-tweak' into 'master' · d4848586
      Nathan Harris authored
      Fix README and API Docs
      
      See merge request Mordil/swift-redis-nio-client!49
      d4848586
    • Nathan Harris's avatar
      Fix README and API Docs · 06c0aeed
      Nathan Harris authored
      Motivation:
      
      The emojis in the README were not rendered consistently in the docs and on different screen form factors making a poor UX.
      
      Modifications:
      
      The CI config now properly sends the custom theme to Jazzy, and the README no longer has the `🔔` emoji in the disclaimer header.
      
      Result:
      
      A consistent UX with the README and proper API docs referring to GitLab
      06c0aeed
    • Nathan Harris's avatar
      Update README · 23a8d445
      Nathan Harris authored
      Motivation:
      
      After moving to GitLab, and while still having a GitHub mirror, it is important to drive people to the proper location for getting help and reporting bugs or feature requests.
      
      Also, some information should be updated to include new tags, formatting, and a link to the new API docs.
      
      Modifications:
      
      README is updated to point users to the GitLab repository and to have up-to-date information about the project.
      
      Result:
      
      Users should know where to reach project maintainers and where to find documentation.
      23a8d445
    • Nathan Harris's avatar
      Merge branch '45-api-docs' into 'master' · 3b5faf04
      Nathan Harris authored
      45 -- Add API Documentation
      
      See merge request Mordil/swift-redis-nio-client!48
      3b5faf04
    • Nathan Harris's avatar
      45 -- Add API Documentation · dd839fdf
      Nathan Harris authored
      Motivation:
      
      Users need a quick reference available online that is up to date.
      
      Modifications:
      
      Add CI job to generate and publish API docs with Jazzy
      
      Result:
      
      Users can view API docs that are updated when new releases are tagged at https://mordil.gitlab.io/swift-redis-nio-client
      dd839fdf
  6. 06 Jun, 2019 7 commits
    • Nathan Harris's avatar
      Merge branch 'se-0226' into 'master' · 6f6fe74c
      Nathan Harris authored
      Rename package to match repo
      
      See merge request Mordil/swift-redis-nio-client!47
      6f6fe74c
    • Nathan Harris's avatar
      Rename package to match repo · dfbccf4c
      Nathan Harris authored
      Motivation:
      
      SE-0226 changes how SPM resolves a dependency graph and as part of the accepted proposal was to require package names to match their repo URL segments.
      
      Modifications:
      
      Change package from `redis-nio` to `swift-redis-nio-client`
      
      Result:
      
      The project should compliant with SE-0226: https://github.com/apple/swift-evolution/blob/master/proposals/0226-package-manager-target-based-dep-resolution.md
      dfbccf4c
    • Nathan Harris's avatar
      Merge branch 'gitlab' into 'master' · dcc9ceae
      Nathan Harris authored
      Migrate from CircleCI to GitLab CI
      
      See merge request Mordil/swift-redis-nio-client!46
      dcc9ceae
    • Nathan Harris's avatar
      Migrate from CircleCI to GitLab CI · 67fa6f2f
      Nathan Harris authored
      Motivation:
      
      Now that the project has migrated from GitHub, it can now fully use GitLab CI.
      
      Modifications:
      
      Removed `circle.yml` and added `.gitlab-ci.yml` files
      
      Result:
      
      GitLab CI should be fully supported
      67fa6f2f
    • Nathan Harris's avatar
      Merge pull request #45 from Mordil/renaming · a765914e
      Nathan Harris authored
      Rename `NIORedis` to `RedisNIO`
      a765914e
    • Nathan Harris's avatar
      Rename `NIORedis` to `RedisNIO` · e81f9546
      Nathan Harris authored
      Motivation:
      
      The SSWG has identified a fast approaching reality of namespace clashes in SPM within the ecosystem and has proposed a rule on names that `NIORedis` no longer complies with.
      
      Modifications:
      
      All references to `NIORedis` have been switched to `RedisNIO` as this module name is unique (at least within GitHub's public repositories).
      
      The goals for this name are as follows:
      
      1. To indicate that this is a Redis client library that is built with SwiftNIO
      2. That it is a lower level library, as it directly exposes SwiftNIO as an implementation detail
          2a. The idea being that a higher level library (`Redis`) will be used, and to "go one level deeper" in the stack, you append the "deeper" `NIO` postfix
      3. It follows a naming pattern adopted by Vapor who has expressed their desire to adopt this library as their Redis implementation
      
      Result:
      
      A repository, package name, and module name that are unique across GitHub's public repositories that achives the goals outlined above.
      e81f9546
    • Nathan Harris's avatar
      Merge pull request #41 from Mordil/40-metrics · 7ae20244
      Nathan Harris authored
      Implement Basic Metrics (#40)
      7ae20244
  7. 05 Jun, 2019 2 commits
    • Nathan Harris's avatar
      Implement Basic Metrics (#40) · 9df65396
      Nathan Harris authored
      Motivation:
      
      End users will want to capture some baseline performance metrics that can only be accurately gathered at this level of the stack.
      
      Modifications:
      
      Added new `RedisMetrics` struct that retains all SwiftMetrics objects used throughout the system lifecycle, and appropriate code to track desired metrics.
      
      Result:
      
      Users now have a way to peek into the system's performance to understand what NIORedis is being asked to do from their usage.
      9df65396
    • Nathan Harris's avatar
      Add Xcode 11 `.swiftpm` to `.gitignore` · 0b284912
      Nathan Harris authored
      0b284912
  8. 28 May, 2019 1 commit
    • Nathan Harris's avatar
      Update License Notice for SwiftLog & SwiftMetrics · b0d0882e
      Nathan Harris authored
      Motivation:
      
      The project has adopted the `swift-log` and `swift-metrics` API packages, and the project's license needs to include attributions to their authors.
      
      Modifications:
      
      `NOTICE.txt` now lists `swift-log` and `swift-metrics` from Apple.
      
      Result:
      
      Apple has been properly attributed for the code from `swift-log` and `swift-metrics`
      b0d0882e
  9. 27 May, 2019 5 commits
    • Nathan Harris's avatar
      Merge pull request #43 from Mordil/blocking-pop · f6facaa2
      Nathan Harris authored
      Add Blocking List Pop Commands
      f6facaa2
    • Nathan Harris's avatar
      Add Blocking List Pop Commands · eaa9d2bf
      Nathan Harris authored
      Motivation:
      
      To be a comprehensive library, all commands should be implemented, even if they are highly discouraged. List's collection of commands were missing `brpop`, `blpop`, and `brpoplpush`.
      
      Modifications:
      
      `brpop`, `blpop` and `brpoplpush` are supported with defaults and overloads for an easier API.
      
      Result:
      
      Users now have access to `brpop`, `blpop` and `brpoplpush` commands.
      eaa9d2bf
    • Nathan Harris's avatar
      Merge pull request #42 from Mordil/blocking-zpop · 0c4db212
      Nathan Harris authored
      Add Blocking Sorted Set Pop Commands
      0c4db212
    • Nathan Harris's avatar
      Add Blocking Sorted Set Pop Commands · 73922325
      Nathan Harris authored
      Motivation:
      
      To be a comprehensive library, all commands should be implemented, even if they are highly discouraged. Sorted Set's collection of commands were missing `bzpopmin` and `bzpopmax`.
      
      Modifications:
      
      `bzpopmin` and `bzpopmax` are supported with defaults and overloads for an easier API.
      `RedisClient.channel` is now `internal` to have access during testing for bypassing normal guards for closing connections.
      
      Result:
      
      Users now have access to `bzpopmin` and `bzpopmax` commands.
      73922325
    • Nathan Harris's avatar
      Improve Redis Channel Pipeline Debugging · d0da3e76
      Nathan Harris authored
      Motivation:
      
      Debugging and properly handling errors was difficult as the `ChannelHandler` names were the default generic names, in addition the `RedisCommandHandler` did not pipe errors further up the pipeline.
      
      Modifications:
      
      `RedisCommandHandler` now calls `context.fireErrorCaught(error)` when receiving errors, and the default Redis `ChannelPipeline` handlers are added with debugging names.
      
      Result:
      
      It should be easier for debugging purposes to work with any Redis `ChannelPipeline`.
      d0da3e76
  10. 18 May, 2019 1 commit
  11. 02 May, 2019 3 commits
    • Nathan Harris's avatar
      Minor comment fixes · d9d61baf
      Nathan Harris authored
      d9d61baf
    • Nathan Harris's avatar
      Tweak README formatting · 3eb76087
      Nathan Harris authored
      3eb76087
    • Nathan Harris's avatar
      Update Readme and Tweak `Redis.makeConnection(...)` · 0131fe43
      Nathan Harris authored
      Motivation:
      
      The goal of the `Redis.makeConnection` factory method is to provide end users with a quick way to jump in and get started with Redis in Swift.
      
      Right now, users have to provide an `EventLoopGroup` instance, when a reasonable default is available for us to define.
      
      Modifications:
      
      - Add: `MultiThreadedEventLoopGroup` for 1 thread as a default argument to the `using:` label in `Redis.makeConnection`
      - Remove: The `with:` label for the password in `Redis.makeConnection`
      - Change: The project README to reflect the current state of the project
      
      Results:
      
      Users should be able to create `RedisConnections` by just defining an IP Address & Port to connect to - and possibly a password.
      
      In addition, the README should now properly direct users on how to use the latest version of the library.
      0131fe43
  12. 01 May, 2019 2 commits