1. 09 Jul, 2019 1 commit
  2. 04 Jul, 2019 1 commit
    • Nathan Harris's avatar
      59 -- Use `RESPValueConvertible` as Generic Constraint · fa227b0e
      Nathan Harris authored
      Motivation:
      
      Johannes continues to provide great insight, and correctly pointed out that `RESPValueConvertible` was being used as an "existential" in all cases.
      
      This can cause unexpected type-erasure and introduce unnecessary cost overhead with dynamic dispatch when in most cases we know the exact value we want for `RESPValue` to execute commands.
      
      Modifications:
      
      - Add new extensions to `Array where Element == RESPValue` for appending and adding elements into them
      - Change `RedisClient.send(command:with:)` to require `[RESPValue]` instead of `[RESPValueConvertible]` as the `with` argument type
      - Change all instances of `RESPValueConvertible` being an "existential" type for method arguments to instead be a generic constraint
      
      Result:
      
      The library should be safeguarded from a class of bugs, with the use of `send` being a bit more straight forward, with some new convenience methods for `[RESPValue]` types.
      fa227b0e
  3. 25 Jun, 2019 1 commit
  4. 06 Jun, 2019 1 commit
    • Nathan Harris's avatar
      Rename `NIORedis` to `RedisNIO` · e81f9546
      Nathan Harris authored
      Motivation:
      
      The SSWG has identified a fast approaching reality of namespace clashes in SPM within the ecosystem and has proposed a rule on names that `NIORedis` no longer complies with.
      
      Modifications:
      
      All references to `NIORedis` have been switched to `RedisNIO` as this module name is unique (at least within GitHub's public repositories).
      
      The goals for this name are as follows:
      
      1. To indicate that this is a Redis client library that is built with SwiftNIO
      2. That it is a lower level library, as it directly exposes SwiftNIO as an implementation detail
          2a. The idea being that a higher level library (`Redis`) will be used, and to "go one level deeper" in the stack, you append the "deeper" `NIO` postfix
      3. It follows a naming pattern adopted by Vapor who has expressed their desire to adopt this library as their Redis implementation
      
      Result:
      
      A repository, package name, and module name that are unique across GitHub's public repositories that achives the goals outlined above.
      e81f9546
  5. 01 May, 2019 1 commit
  6. 01 Apr, 2019 1 commit
    • Nathan Harris's avatar
      Replace `Foundation.Data` with `[UInt8]` type everywhere · 3c53d440
      Nathan Harris authored
      Motivation:
      
      `Foundation.Data` is known to be more expensive than is necessary for this low level of a library, and has some quirks with its usage.
      
      Results:
      
      This library now works with byte arrays (`[UInt8]`) directly, and all references to `Foundation` now explicitly import the exact types they need.
      3c53d440
  7. 28 Mar, 2019 1 commit
    • Nathan Harris's avatar
      Simplify `RedisCommandExecutor` and `RedisConnection` · 9f049eb4
      Nathan Harris authored
      Motivation:
      
      `RedisCommandExecutor` was a complex and "wordy" name that was not 100% clear as to how it relates to other types.
      
      `RedisConnection` also has not had a strong use case shown for it to exists as a separate protocol - using up a great name for the "out of the box" implementation.
      
      Result:
      
      `RedisClient` instead of `RedisCommandExecutor` is more clear as to what it is, in Redis terminology, a communication client.
      
      `RedisConnection` as a concrete class provides an identifiable basic block for making connections to Redis.
      
      `RedisConnection` also saw some fixes to `close()` while having some names and comment blocks tweaked for updated naming.
      9f049eb4
  8. 25 Mar, 2019 1 commit
  9. 21 Mar, 2019 1 commit
  10. 20 Mar, 2019 1 commit
  11. 19 Mar, 2019 1 commit
    • Nathan Harris's avatar
      Refactor `RedisConnection` and `RedisPipeline` into protocols. · 6b30127f
      Nathan Harris authored
      Motivation:
      
      The goal of this commit is to make it easier for library users to implement their own types for creating connections and pipelines without losing all of the convenience command extensions.
      
      This also splits executing commands from the concept of a "connection" to make it more swifty in `RedisPipeline`.
      6b30127f
  12. 13 Mar, 2019 1 commit