Commit 1281724a authored by Nathan Harris's avatar Nathan Harris Committed by Nathan Harris

Make `RedisCommandHandler` final

Motivation:

During SSWG review, feedback was provided that forced a re-evaluation of early design feedback interpretation on composability of RedisNIO.

First understanding was that the desire was to have "customization points" to gain benefits of implementation of RedisCommandHandler, while new understanding is that it just needs to be public in order for users to include it in their own custom ChannelPipeline schemes.

Modifications:

`RedisCommandHandler` is now a final class.

Result:

Users will no longer be able to subclass `RedisCommandHandler`, but gain a super slight performance increase.

This contributes to #47.
parent cc477734
......@@ -30,7 +30,7 @@ public struct RedisCommandContext {
}
/// A `ChannelDuplexHandler` that works with `RedisCommandContext`s to send commands and forward responses.
open class RedisCommandHandler {
public final class RedisCommandHandler {
/// Queue of promises waiting to receive a response value from a sent command.
private var commandResponseQueue: CircularBuffer<EventLoopPromise<RESPValue>>
private var logger: Logger
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment