1. 26 Jan, 2021 21 commits
    • Michal Privoznik's avatar
      fixup · 14286ae3
      Michal Privoznik authored
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
    • Michal Privoznik's avatar
    • Michal Privoznik's avatar
      fixup? :( · 86d1cdca
      Michal Privoznik authored
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
    • Michal Privoznik's avatar
      qemu: Pass FD for usb-host whenever possible · 498051dd
      Michal Privoznik authored
      This originally started as bug 1595525 in which namespaces and
      libusb used in QEMU were not playing nice with each other. The
      problem was that libusb built a cache of USB devices it saw
      (which was a very limited set because of the namespace) and then
      expected to receive udev events to keep  the cache in sync.
      Without going to deep into what the problem was, libusb added a
      new API for opening USB devices that avoids using cache which
      QEMU incorporated and exposes under "hostdevice" attribute. Which
      is even nicer is that QEMU uses qemu_open() for opening path
      passed in the attribute which means Libvirt can simply open the
      USB device itself and just pass the FD.
      Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1877218Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
    • Michal Privoznik's avatar
      virusb: Introduce virUSBDeviceOpen() · 7966ff93
      Michal Privoznik authored
      This function is a simple wrapper over open() that gets bus and
      device numbers at the input and returns FD to
      /dev/bus/usb/$bus/$dev file.
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
    • Michal Privoznik's avatar
      tools: Set IFS for bash completion script · b889594a
      Michal Privoznik authored
      The way our bash completion string is that is gets user's input
      and lets virsh completion code do all the work by calling 'virsh
      complete -- $INPUT". The 'complete' command is a "secret",
      unlisted command that exists solely for this purpose. After it
      has done it's part, it prints candidates onto stdout, each
      candidate on its own line, e.g. like this:
        # virsh complete -- "net-u"
      These strings are then stored into a bash array $A like this:
        A=($($1 ${CMDLINE} complete -- "${INPUT[@]}" 2>/dev/null))
      This array is then thrown back at bash completion to produce
      desired output. So far so good. Except, when there is an option
      with space. For instance:
        # virsh complete -- start --domain ""
        uefi\ duplicate
      Bash interprets that as another array item because by default,
      Internal Field Separator (IFS) = set of characters that bash uses
      to split words at, is: space, TAB, newline. We don't want space
      nor TAB. Therefore, we have to set $IFS when storing 'virsh
      complete' output into the array.
      Thanks to Peter who suggested it.
      Resolves: #116Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Michal Privoznik's avatar
      vsh: Allow double quotes imbalance for auto completion in vshCommandStringGetArg() · aad2262b
      Michal Privoznik authored
      If user is trying to auto complete a value that contains a space,
      they have two options: use backslash to escape space or use
      quotes, like this:
        virsh # start --domain "domain with space<TAB>
      However, in this case our tokenizer sees imbalance in (double)
      quotes: there is a starting one that's missing its companion.
      Well, that's obvious - user is still in process of writing the
      command. What we need to do in this case is to ignore the
      imbalance and return success (from the tokenizer) - readline will
      handle closing the quote properly.
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Michal Privoznik's avatar
      vsh: Rework how option to complete is found · 22904b57
      Michal Privoznik authored
      The way that auto completion works currently is that user's input
      is parsed, and then we try to find the first --option (in the
      parsed structure) that has the same value as user's input around
      where <TAB> was pressed. For instance, for the following input:
        virsh # command --arg1 hello --arg2 world<TAB>
      we will see "world" as text that user is trying to autocomplete
      (this is affected by rl_basic_word_break_characters which
      readline uses internally to break user's input into individual
      words) and find that it is --arg2 that user is trying to
      autocomplete. So far so good, for this naive approach. But
      consider the following example:
        virsh # command --arg1 world --arg2 world<TAB>
      Here, both arguments have the same value and because we see
      "world" as text that user is trying to autocomplete we would
      think that it is --arg1 that user wants to autocomplete. This is
      obviously wrong.
      Fortunately, readline stores the current position of cursor (into
      rl_point) and we can use that when parsing user's input: whenever
      we reach a position that matches the cursor then we know that
      that is the place where <TAB> was pressed and hence that is the
      --option that user wants to autocomplete. Readline stores the
      cursor position as offset (numbered from 1) from the beginning of
      user's input. We store this input into @parser->pos initially,
      but then advance it as we tokenize it. Therefore, what we need is
      to store the original position too.
      Thanks to Martin who helped me with this.
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Michal Privoznik's avatar
      vshReadlineParse: Escape list of candidates earlier · f61a4e91
      Michal Privoznik authored
      The way our completer callbacks work is that they return all
      possible candidates and then vshCompleterFilter() is called to
      prune the list of all candidates removing those which don't match
      user's input. This allows us to have simpler completer callbacks
      as their only job is to fetch all possible candidates.
      Anyway, if the completion candidate we're returning contains a
      space, it has to be escaped (shell like escaping), unless there
      is already a quote character (single quote or double quote).
      But ordering is critical. Completer callback returns string
      without any escaping, but the filter function sees the user input
      escaped. For instance, if user's input is "domain with
      space<TAB>" then the filtering function gets "domain\ with\
      space" as user's input but completer returns "domain with space".
      Since these two strings don't match the filtering function
      removes this candidate from the list. What we need to do is to
      escape strings before calling the filtering function. This way,
      the filtering function will see two same strings.
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Michal Privoznik's avatar
      vshReadlineParse: Rename @buf to @Line · c31e80c6
      Michal Privoznik authored
      In next commit the block that does escaping of returned string
      will be brought into this block. But both contain variable @buf
      and use it in different contexts. Rename @buf from @state == 0
      block to @Line which reflects its purpose better.
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Michal Privoznik's avatar
      vshReadlineParse: Use g_auto*() · 10005213
      Michal Privoznik authored
      Instead of freeing @partial and @buf explicitly, we can use
      g_auto*() to do that automatically.
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Michal Privoznik's avatar
      vshReadlineParse: Bring some variables into !state block · e19ecee5
      Michal Privoznik authored
      On readline completion vshReadlineCompletion() is called which
      does nothing more than calling rl_completion_matches() with
      vshReadlineParse() as a callback. This means, that
      vshReadlineParse() is called repeatedly, each time returning next
      completion candidate, until it returns NULL which is interpreted
      as the end of the list of candidates.
      The function takes two parameters: @text which is a portion of
      input line around cursor when TAB was pressed, and @state. The
      @state is an integer that is zero on the very first call and
      non-zero on each subsequent call (in fact, readline does @state++
      on each call).
      Anyway, the idea is that the callback gets the whole list of
      candidates on @state == 0 and returns one candidate at each call.
      And this is what vshReadlineParse() is doing but some variables
      (@partial, @cmd and @opt) are really used only in the @state == 0
      case but declared for whole function. We can limit their scope by
      declaring them inside the @state == 0 body which also means that
      they don't have to be static anymore.
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Michal Privoznik's avatar
      vsh: Don't break word on backslash · df9f1efc
      Michal Privoznik authored
      A backslash is the way we escape characters in virsh. For
        virsh # start domain\ with\ long\ name
      For readline completion, we do not want to get four separate
      words ("domain", "with", "long", "name").  This means, that we
      can't use virBufferEscapeShell() because it doesn't escape spaces
      the way we want.
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Michal Privoznik's avatar
      vshCommandStringGetArg: Drop @sz · 9b954258
      Michal Privoznik authored
      This variable is unused since introduction of the function in
      Signed-off-by: default avatarMichal Privoznik <mprivozn@redhat.com>
      Reviewed-by: Jano Tomko's avatarJán Tomko <jtomko@redhat.com>
    • Jiri Denemark's avatar
      cpu_map: Remove intel-pt from x86 CPU models · 4901314d
      Jiri Denemark authored
      As explained in QEMU commit 4c257911dcc7c4189768e9651755c849ce9db4e8
      intel-pt features should never be included in the CPU models as it was
      not supported by KVM back then and even once it started to be supported,
      users have to enable it by passing pt_mode=1 parameter to kvm_intel
      module. The Icelake-* CPU models with intel-pt included were added to
      QEMU 3.1.0 and removed right in the following 4.0.0 release (and even in
      3.1.1 maintenance release).
      In libvirt 6.10.0 I introduced 'removed' attribute for features included
      in our CPU model definitions which we can use to drop intel-pt from
      Icelake-* CPU models. Back then I explained we can safely do so only for
      features which could never be enabled, which is not the case of intel-pt.
      Theoretically, it could be possible to create an environment in which
      QEMU would enable intel-pt without asking for it explicitly: it would
      need to use a new enough kernel (not available at the time of QEMU
      3.1.0) and pt_mode KVM parameter in combination with QEMU 3.1.0 running
      a domain with q35 machine type and all that on a CPU which didn't really
      exist at that time.
      Migrating such domain to a host with newer SW stack including libvirt
      with this patch applied would result in incompatible guest ABI (the
      virtual CPU would lose intel-pt). However, QEMU changed its CPU models
      unconditionally and thus migration would not work even without this
      patch. That said, it is safe to follow QEMU and remove the feature from
      Icelake-* CPU models in our cpu_map.
      https://bugzilla.redhat.com/show_bug.cgi?id=1853972Signed-off-by: Jiri Denemark's avatarJiri Denemark <jdenemar@redhat.com>
      Reviewed-by: Tim Wiederhake's avatarTim Wiederhake <twiederh@redhat.com>
    • Cédric Bosdonnat's avatar
      Fix format network dns doc · d5283b7b
      Cédric Bosdonnat authored
      The code block on the srv name in the formatnetwork page is confusing
      since the actual parameter is service. Moving the code block to the
      service work makes it better.
      Reviewed-by: Andrea Bolognani's avatarAndrea Bolognani <abologna@redhat.com>
      Signed-off-by: default avatarCédric Bosdonnat <cbosdonnat@suse.com>
    • Daniel P. Berrangé's avatar
      gitlab: force dwarf4 format for debuginfo in Fedora rawhide · e603efb6
      Daniel P. Berrangé authored
      Fedora 34 rawhide has pulled in a new GCC 11 build which now
      defaults to dwarf5 format. This format is not compatible with
      the pdwtags program used in our test suite to validate the
      RPC files.
      We have no need for debuginfo in CI except for pdwtags,
      so the simplest short term fix is to force the older dwarf
      version in the hope that a fixed dwarves release will
      arrive before Fedora 34 is released, or GCC 11 becomes more
      widespread. Eventually we might need to figure out a way to
      probe for compatibility but for now, we'll hope that any
      distro with GCC 11 will be able to have a fixed dwarves too.
      https://bugzilla.redhat.com/show_bug.cgi?id=1919965Reviewed-by: Erik Skultety's avatarErik Skultety <eskultet@redhat.com>
      Signed-off-by: Daniel P. Berrangé's avatarDaniel P. Berrangé <berrange@redhat.com>
    • Andrea Bolognani's avatar
      ci: Refresh dockerfiles · 0947902d
      Andrea Bolognani authored
      dtrace is now also installed when cross-building.
      Signed-off-by: Andrea Bolognani's avatarAndrea Bolognani <abologna@redhat.com>
      Reviewed-by: Daniel P. Berrangé's avatarDaniel P. Berrangé <berrange@redhat.com>
    • Helmut Grohne's avatar
      meson: Fix cross-building of dtrace probes · 44b34813
      Helmut Grohne authored
      dtrace invokes the C compiler, so when cross-building we need
      to make sure that $CC is set in the environment and that it
      points to the cross-compiler rather than the native one.
      Until https://github.com/mesonbuild/meson/issues/266
      is addressed, the workaround is to call dtrace via env(1).
      https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980334Signed-off-by: Helmut Grohne's avatarHelmut Grohne <helmut@subdivi.de>
      Reviewed-by: Andrea Bolognani's avatarAndrea Bolognani <abologna@redhat.com>
      Reviewed-by: Daniel P. Berrangé's avatarDaniel P. Berrangé <berrange@redhat.com>
    • Dmytro Linkin's avatar
      util: Add phys_port_name support on virPCIGetNetName · 5b1c525b
      Dmytro Linkin authored
      virPCIGetNetName is used to get the name of the netdev associated with
      a particular PCI device. This is used when we have a VF name, but need
      the PF name in order to send a netlink command (e.g. in order to
      get/set the MAC address of the VF).
      In simple cases there is a single netdev associated with any PCI
      device, so it is easy to figure out the PF netdev for a VF - just look
      for the PCI device that has the VF listed in its "virtfns" directory;
      the only name in the "net" subdirectory of that PCI device's sysfs
      directory is the PF netdev that is upstream of the VF in question.
      In some cases there can be more than one netdev in a PCI device's net
      directory though. In the past, the only case of this was for SR-IOV
      NICs that could have multiple PF's per PCI device. In this case, all
      PF netdevs associated with a PCI address would be listed in the "net"
      subdirectory of the PCI device's directory in sysfs. At the same time,
      all VF netdevs and all PF netdevs have a phys_port_id in their sysfs,
      so the way to learn the correct PF netdev for a particular VF netdev
      is to search through the list of devices in the net subdirectory of
      the PF's PCI device, looking for the one netdev with a "phys_port_id"
      matching that of the VF netdev.
      But starting in kernel 5.8, the NVIDIA Mellanox driver began linking
      the VFs' representor netdevs to the PF PCI address [1], and so the VF
      representor netdevs would also show up in the net
      subdirectory. However, all of the devices that do so also only have a
      single PF netdev for any given PCI address.
      This means that the net directory of the PCI device can still hold
      multiple net devices, but only one of them will be the PF netdev (the
      others are VF representors):
      $ ls '/sys/bus/pci/devices/0000:82:00.0/net'
      ens1f0  eth0  eth1
      In this case the way to find the PF device is to look at the
      "phys_port_name" attribute of each netdev in sysfs. All PF devices
      have a phys_port_name matching a particular regex
      Since there can only be one PF in the entire list of devices, once we
      match that regex, we've found the PF netdev.
      [1] - https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
      Co-Authored-by: Moshe Levi's avatarMoshe Levi <moshele@nvidia.com>
      Signed-off-by: default avatarDmytro Linkin <dlinkin@nvidia.com>
      Reviewed-by: default avatarAdrian Chiris <adrianc@nvidia.com>
      Reviewed-by: default avatarLaine Stump <laine@redhat.com>
    • Moshe Levi's avatar
      util: add virNetDevGetPhysPortName · 97ebb982
      Moshe Levi authored
      This commit add virNetDevGetPhysPortName to read netdevice
      phys_port_name from sysfs. It also refactor the code so
      virNetDevGetPhysPortName and virNetDevGetPhysPortID will use
      same method to read the netdevice sysfs.
      Signed-off-by: Moshe Levi's avatarMoshe Levi <moshele@nvidia.com>
      Reviewed-by: default avatarLaine Stump <laine@redhat.com>
  2. 24 Jan, 2021 2 commits
  3. 22 Jan, 2021 17 commits