NoMAD trims password in keychain

A User reported an issue with NoMAD where it would ask him to login every time he logged in to his Mac. UseKeychain and all the other preferences are set correctly.

I opened up the log stream and used "killall NoMAD && kdestroy" to simulate a new login. Although a keychain item was present in the login.keychain, NoMAD prompted for login.

In the logs i saw a "preauthentication failed" message. After looking at the Password in the keychain i saw that it was missing the last character. The first login went fine, so NoMAD used the correct password for this login, it just saved the wrong version to the keychain. The next time I guess NoMAD tried to login with the wrong password, saw that it didn't work, deleted the keychain entry and prompted the user for the correct password.

The same issue is reproducible on a different machine with a different AD Account, so it should have something to do with the format of the password. I can provide a similar Password to the developers to make testing possible.

The password is nothing too fancy though so it is kinda strange.

macOS is 10.12.6 and NoMAD is basically 1.1.4 (1.1.5 to be exact).