Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • A android
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 558
    • Issues 558
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Insights
    • Issue
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • LineageOS
  • issues
  • android
  • Issues
  • #3196
Closed
Open
Created Mar 26, 2021 by advlpr@advlpr

ginkgo: Drop QC location support

Notice

The following is a copy/paste from this issue with some minor changes.

Duplicated here for the sake of completeness.

Note that the mentioned changes were introduced in lineage-16.0.

Expected Behavior

UnifiedNlp could be run as a Network Provider and a Fused Location Provider.

Current Behavior

UnifiedNlp does not work.

Possible Reason

In introduced configurations, specifically those in overlay/frameworks/base/core/res/res/values/config.xml, the default settings for config_enableNetworkLocationOverlay and config_enableFusedLocationOverlay are false, with the settings config_networkLocationProviderPackageName, config_fusedLocationProviderPackageName and config_comboNetworkLocationProvider being com.qualcomm.location, which forces com.qualcomm.location to be the only package allowed to provide network/fused location, therefore effectively breaks UnifiedNlp.

Possible Solution

Set config_enableNetworkLocationOverlay and config_enableFusedLocationOverlay to be true. Or better, revert these commits, as QC Location is proprietary and closed-source, blatantly against LineageOS being free and open-source.

Steps to Reproduce

  1. Install UnifiedNlp and Mozilla Nlp Backend.
  2. Try to obtain the geolocation in the battery saving mode (instead of device, "GPS").
  3. Failed.

Request

The issue was solved for polaris, beryllium, and others, but not for ginkgo.

I am kindly requesting a fix for ginkgo for both lineage-17.1 and the upcoming lineage-18.1.

Thanks.

Note

As detailed in this blog post, as of 2021-04-12, these devices still have the QC location blob:

  • Asus ROG Phone 2 (I001D)
  • Asus Zenfone 5Z (Z01R)
  • Asus Zenfone 6 (I01WD)
  • Motorola Moto Z Play (addison)
  • Xiaomi Redmi Note 8/8T (gingko)

/device ginkgo /version lineage-17.1 /date 2021-03-15 /kernel 4.14.117-perf+ /baseband /mods F-Droid, UnifiedNLP

I have read the directions.

Edited Apr 17, 2021 by advlpr
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking