ETag filter breaks certain sites (here: gitpod.io)
Prerequisites
-
Can you reproduce the problem in a fresh Firefox profile with only ClearURLs? -
Are you running the latest version of ClearURLs? -
Have you changed settings under about:config
? -> No, I installed Firefox just to test this. My main browser is Chrome
Description
GitPod is a website that allows you open any git repository from GitHub/GitLab/BitBucket in a VSCode workspace in your browser. They are not "evil" and the site completely breaks when ETag filtering is enabled.
Steps to Reproduce
- Sign in to https://gitpod.io using your GitLab account (it's free)
- Open this link to launch a GitPod workspace for this repository: https://gitpod.io/#https://gitlab.com/KevinRoebert/ClearUrls/-/tree/master (Note: you can also append any other GitHub/GitLab/BitBucket repository url after the #, but you may need to sign in with your account from the corresponding site)
- Watch it break
Expected behavior: GitPod should load normally and all features work.
Actual behavior: Most GitPod features break. Notably, when filtering ETag requests, VSCode switches to a light theme. (ew)
System
- Version: 1.21.0
- Platform: Windows 10 Enterprise Version 1909 64-bit
- Country: Germany (DE)
Log
Solution/Proposal
My current workaround is to just disable ETag filtering completely, which might not be ideal. I suggest adding exceptions for sites known to break when stripping their ETags. Alternatively, there's #494 (closed) suggesting ETag filtering to be off by default, and #913 suggesting a per-site switch for it