Commits · v210_asm · James Darnley / ffmpeg

Jan 17, 2016

avcodec/v210: add avx2 version of the line decoder · 0043ade0
James Darnley authored Jan 17, 2016
```
Not noticably faster (or slower).
```
0043ade0

avcodec/diracdec: Fix qfactor/offset tables · 5fbd97fc

Michael Niedermayer authored Jan 13, 2016



It seems the previous tables where calculated with 32bit integers ignoring
overflows.
Also check for the max qindex, the value is choosen so that the qfactor/offset
fit in int32.

Fixes: 070b7914fd5dfe8f93248bea71363410/asan_static-oob_c8d034_2764_258e20f4a3c79158aecddb61a833d756.drc
Fixes out of array reads

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

5fbd97fc

libavcodec/aacenc_tnc.c: remove unused variable w2 · 69697be9
Claudio Freire authored Jan 17, 2016
```
No longer needed since previous commit
```
69697be9

AAC encoder: TNS fixes on short windows · 3d0849cc

Claudio Freire authored Jan 16, 2016

TNS was computing filter coefficients incorrectly for short windows
due to a few coefficient addressing bugs. Fixing them fixes lots of
instability with transients (short windows).

3d0849cc

AAC encoder: use signed coeffs when measuring IS energy · df3fa482

Claudio Freire authored Jan 16, 2016

I/S energy, especially when it comes to phase cancellations,
needs to use signed coefficients as input, yet it was using
abs'd coefficients. That was a slight bug.

df3fa482

AAC encoder: enforce SF delta in PNS and IS SFs · 60a76f8b

Claudio Freire authored Jan 16, 2016

Make sure to properly enforce maximum scalefactor delta in PNS
and I/S, not as an absolute range but relative to the previous
and first scalefactor, the latter important since PNS uses an
implicit inicial scalefactor derived from the global gain, and
encoded in a different way, which makes a big difference in the
allowed range.

60a76f8b

avcodec/v210: document the requirement for sample_factor · 4c430738

James Darnley authored Jan 15, 2016

The sample factor must be the same for both 8- and 10-bit functions chosen
otherwise the output will be incorrect.

4c430738

avcodec/v210: add avx2 version of the 10-bit line encoder · 2cba1825
James Darnley authored Jan 15, 2016
```
Around 25% faster than the ssse3 version.
```
2cba1825
avcodec/v210: add avx2 version of the 8-bit line encoder · 3836f404
James Darnley authored Dec 30, 2015
```
Around 35% faster than the avx version.

Signed-off-by: Henrik Gramner <henrik@gramner.com>
```
3836f404
fate: add 10-bit v210 encoder tests · 61625dcc
James Darnley authored Jan 15, 2016

61625dcc

swscale/x86/rgb2rgb_template: Fix planar2x() for short width · c8a9aaab

Michael Niedermayer authored Jan 17, 2016

Fixes: 451b3e0cf956c0bd2f27ed753ac24050/asan_heap-oob_2873c01_3231_7ed10a9464d15f0d57277f5917c566a8.AVI

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

c8a9aaab

remove all uses of the deprecated avpicture_get_size() function · a6dc1eb8
Eddie Hao authored Jan 16, 2016
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
a6dc1eb8

swscale/swscale_unscaled: Fix odd height inputs for bayer_to_yv12_wrapper() · 757248ea

Michael Niedermayer authored Jan 17, 2016



Fixes: 372d2df1f04b49e25f109f07f90b1505/asan_heap-oob_2835d2e_8501_99e0114d7ba3a6db885d0b4684d200c1.cine
Fixes out of array read

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

757248ea

swscale/swscale_unscaled: Fix odd height inputs for bayer_to_rgb24_wrapper() · ad3b6fa7

Michael Niedermayer authored Jan 17, 2016



Fixes: 372d2df1f04b49e25f109f07f90b1505/asan_heap-oob_2835d2e_8501_99e0114d7ba3a6db885d0b4684d200c1.cine
Fixes out of array read

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

ad3b6fa7

ffmpeg: fix sws_dict leak on error exit · 7a0361b0

Michael Niedermayer authored Jan 16, 2016

Fixes: 1b79b985cdf860ffa228c00ee5497051/signal_sigsegv_1f99d24_3549_86d92054a79f6ff900fbaf03f8012b32.aif

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

7a0361b0

x86/fixed_dsp: add ff_butterflies_fixed_sse2 · dee579ff

James Almer authored Jan 15, 2016



Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

dee579ff

Jan 16, 2016

avcodec/wmaenc: Check input for finiteness · aa6aa2ef

Michael Niedermayer authored Jan 16, 2016



Fixes out of array read
Fixes: 1b79b985cdf860ffa228c00ee5497051/signal_sigsegv_1f99d24_315_f0f1fdb451264b1138e9c24eb7d49181.wv

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

aa6aa2ef

avcodec/aacenc: Check both channels for finiteness · 057549a9

Michael Niedermayer authored Jan 16, 2016

Fixes null pointer dereference
Fixes: 10412fc52ecc6eab40ed67f82ca7b372/signal_sigsegv_2618c99_2129_f808373959e46afb165593332799ffbc.aif

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

057549a9

lavf/matroskadec: Get sample size from private data · 535d09a5
Mats Peterson authored Jan 15, 2016
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
535d09a5
lavf/mov: Don't limit fourcc 0 -> raw/twos to version 0 sample descriptions · a51c8a68
Mats Peterson authored Jan 15, 2016
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
a51c8a68

Jan 15, 2016

avcodec/motion_est: Attempt to fix "short data segment overflowed" on IA64 · d7c75a5d

Michael Niedermayer authored Jan 15, 2016



This decreases the MV related encoding table sizes
This should have little effect on real world video encoding performance

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

d7c75a5d

mpeg4videodec: silence ubsan warning · 564dd3f0

Andreas Cadhalpun authored Jan 15, 2016



s->ac_val[0][0] is of type 'int16_t [16]', but points into a larger buffer.
Here it is used as base pointer to find the correct position in the
larger buffer by adding 's->block_index[n] * 16' and thus as 'int16_t *'.

This fixes clang's ubsan runtime error: index out of bounds for type
'int16_t [16]'

Fixes: test_case.mp4

Found-by: Tyson Smith <twsmith@mozilla.com>
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

564dd3f0

lavu/x86/lls: add fma3 optimizations for update_lls · 5989add4

Ganesh Ajjanagadde authored Jan 13, 2016



This improves accuracy (very slightly) and speed for processors having
fma3.

Sample benchmark (fate flac-16-lpc-cholesky, Haswell):
old:
5993610 decicycles in ff_lpc_calc_coefs,      64 runs,      0 skips
5951528 decicycles in ff_lpc_calc_coefs,     128 runs,      0 skips

new:
5252410 decicycles in ff_lpc_calc_coefs,      64 runs,      0 skips
5232869 decicycles in ff_lpc_calc_coefs,     128 runs,      0 skips

Tested with FATE and --disable-fma3, also examined contents of
lavu/lls-test.

Reviewed-by: James Almer <jamrial@gmail.com>
Reviewed-by: Henrik Gramner <henrik@gramner.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

5989add4

avfilter/af_sidechaincompress & af_agate: use audio fifo from lavu · d4ce63a1
Paul B Mahol authored Jan 15, 2016
```
Fixes regression causing segfault.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
```
d4ce63a1
avformat/riff: add C210 FourCC (Canopus C210) · eded2e4f
Piotr Bandurski authored Jan 14, 2016

eded2e4f
avformat/riff: add YUYV FourCC (Drastic YUYV) · 23ac3554
Piotr Bandurski authored Jan 14, 2016

23ac3554
avfilter: add ahistogram multimedia filter · 7d76294c
Paul B Mahol authored Dec 29, 2015
```
Signed-off-by: Paul B Mahol <onemda@gmail.com>
```
7d76294c
x86/intmath: add missing early clobber to output operands · 36778627
James Almer authored Jan 15, 2016
```
Signed-off-by: James Almer <jamrial@gmail.com>
```
36778627
avcodec/x86/fmtconvert: Add emms to int32_to_float_fmul_array8_sse() · da6f3451
Michael Niedermayer authored Jan 15, 2016
```
this should fix checkasm on x86_64-archlinux-gcc-valgrind

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
da6f3451
avfilter/vaf_spectrumsynth: Fix mixed declaration and statment · 48f5244d
Michael Niedermayer authored Jan 15, 2016
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
48f5244d

avformat/hls: Even stricter URL checks · cfda1bea

Michael Niedermayer authored Jan 15, 2016



This fixes a null pointer dereference at least

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

cfda1bea

avformat/hls: More strict url checks · 6ba42b64

Michael Niedermayer authored Jan 15, 2016



No case is known where these are needed

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

6ba42b64

avcodec/rmdec: add missing av_log argument · e3c188e7

James Almer authored Jan 15, 2016



Also change the format specifier to expect an unsigned int

Signed-off-by: James Almer <jamrial@gmail.com>

e3c188e7

lavf/mov: Confine 0x00000000 to raw/twos fourcc mapping to version 0 sample descriptions · b58cfa61

Mats Peterson authored Jan 13, 2016



Confine the 0x00000000 to 'raw '/'twos' fourcc mapping to old version 0
sound sample descriptions, since they are the only valid sample
descriptions for this type of mapping.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

b58cfa61

avcodec/pngenc: Fix mixed up linesizes · 8f4c3e4b

Michael Niedermayer authored Jan 15, 2016



Fixes out of array accesses
Fixes: 0cf176e6d3ab9fe924f39738e513f547/asan_generic_4a54aa_3431_aaa28be1cb32e307a9890cad06f84fba.avi

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

8f4c3e4b

avcodec/pngenc: Replace memcpy by av_image_copy() · 7ec9c5ce

Michael Niedermayer authored Jan 15, 2016



Fixes out of array access
Fixes: 0cf176e6d3ab9fe924f39738e513f547/asan_generic_4a54aa_3431_aaa28be1cb32e307a9890cad06f84fba.avi

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

7ec9c5ce

Jan 14, 2016

asfdec_o: check for too small size in asf_read_unknown · c29e87ad

Andreas Cadhalpun authored Jan 06, 2016



This fixes infinite loops due to seeking back.

Reviewed-by: Alexandra Hájková <alexandra.khirnova@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

c29e87ad

asfdec_o: break if EOF is reached after asf_read_packet_header · 0e32153e

Andreas Cadhalpun authored Jan 06, 2016



asf_read_payload can unset eof_reached, so check it also before calling
that function.

This fixes infinite loops.

Reviewed-by: Alexandra Hájková <alexandra.khirnova@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

0e32153e

asfdec_o: make sure packet_size is non-zero before seeking · 3776a729

Andreas Cadhalpun authored Jan 06, 2016



This fixes infinite loops due to seeking back.

Reviewed-by: Alexandra Hájková <alexandra.khirnova@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

3776a729

asfdec_o: prevent overflow causing seekback · 74474750

Andreas Cadhalpun authored Jan 06, 2016



This fixes infinite loops.

Reviewed-by: Alexandra Hájková <alexandra.khirnova@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

74474750