The use of function compact() is forbidden
Probably we can avoid the compact() function from our code, accordingly to our linter (?)
534 | ERROR | The use of function compact() is forbidden
https://gitlab.com/ItalianLinuxSociety/ilsmanager/-/jobs/8652991221
In case...
Places that could be fixed, at least:
$ grep -RF -- 'compact(' .
./Http/Controllers/EditController.php: return view($this->view_folder . '.edit', compact('object'));
./Http/Controllers/GadgetRequestController.php: return view($this->view_folder . '.show', compact('gadgetRequest'));
./Http/Controllers/MovementController.php: return view('movement.edit', compact('movement'));
./Http/Controllers/MovementController.php: return view('movement.review', compact('pendings'));
./Http/Controllers/HomeController.php: return view('home', compact('max_members'));
./Http/Controllers/SectionController.php: return view('section.balance', compact('section', 'year', 'rows'));
./Http/Controllers/DocumentationController.php: return view('documentation.index', compact('folder', 'files'));
./Http/Controllers/DocumentationController.php: return view('documentation.preview', compact('content', 'file', 'folder'));
./Http/Controllers/DocumentationController.php: return view('documentation.preview', compact('content', 'file', 'folder'));
From:
compact('lol1', 'lol2')
To:
[
'lol1' => $lol1,
'lol2' => $lol2,
]