Islam Momani (9c6a8e1f) at 06 Aug 12:14
add close down date
Islam Momani (d6e1243f) at 06 Aug 11:33
add date of close down
Islam Momani (81241d71) at 05 Apr 13:44
Snapshots update
Approving it without testing. Because I'm facing some issues with my machine.
Ok. You can add any styling to this in line 725.
We have a specific repo for the assets and I think Mohammad mentioned something like putting all these in the style-guide.
I think the name is misleading. It's saying set target (the method expected to get a string, not a CommentAnnotation).
Why we are rotating the svg here? (I expected it was rotated already when you created the icon)
This is the extra rotation that I was talking about.
I'm not sure about the number 32px. But anyways I suggest replacing this with border-radius: 32px 32px 0 0;
to avoid an extra rotation.
You can add any styling to this in line 725. Does it do the job to replace that position: relative; margin-right: 40px;
with just a display: flex;
?
In my opinion, It's not nice to have these icons here in this file. I feel it should be defined somewhere else with the assets.
Target is a CommentAnnotation
type ?!
I'm not following how the set comment target is going to create a comment. Could you please elaborate more?
Islam Momani (38845a7a) at 20 Dec 08:44
Islam Momani (e187e809) at 20 Dec 08:44
Display individual references - LEAN-1672