Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
hotpotato
hotpotato
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 46
    • Issues 46
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 5
    • Merge Requests 5
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Hot-Potato
  • hotpotatohotpotato
  • Issues
  • #113

Closed
Open
Opened Sep 12, 2019 by Zac Pullar-Strecker@zacpsMaintainer

Issues from Lighthouse audits

I ran all the lighthouse audits on the escalations branch in production mode.

The full report can be viewed here

Notable issues:

Performance

  • DOM size with 77 notifications is 3,147 elements. Ideally we'd reduce this if possible.
  • We should use appropriate font-display options so text is rendered quicker

Accessibility

  • Button missing accessible name (#notifications > div > div:nth-child(2) > a.dropdown-toggle.btn-icon.no-toggle)
  • Some form elements don't have labels (See report)
  • Server links have no screen-readable name
  • Background & Foreground have insufficient contrast (An issue in many places, see report)
  • Some ids are not unique

Best practises

  • Does not use HTTP/2 (See benoitc/gunicorn#1195

PWA

There are quite a few issues here, mostly related to service workers. This may be a somewhat simpler way to support the longstanding goal of a mobile app. However, at least for now it wouldn't be possible to support iOS because while there is some support for PWAs they do not support background operation or push notifications.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: Hot-Potato/hotpotato#113