Commit 88bb577c authored by DavidWyand-GG's avatar DavidWyand-GG

Fix for Issue #128 for Player First Person Shadow

IMPROVEMENT: By default we stop rendering all Player shadows when in
first person and 'renderFirstPerson' is disabled.  Added flag
'firstPersonShadows' to disable this behavior.
parent 4290c1d9
......@@ -252,6 +252,7 @@ PlayerData::PlayerData()
shadowProjectionDistance = 14.0f;
renderFirstPerson = true;
firstPersonShadows = false;
// Used for third person image rendering
imageAnimPrefix = StringTable->insert("");
......@@ -679,6 +680,9 @@ void PlayerData::initPersistFields()
addField( "renderFirstPerson", TypeBool, Offset(renderFirstPerson, PlayerData),
"@brief Flag controlling whether to render the player shape in first person view.\n\n" );
addField( "firstPersonShadows", TypeBool, Offset(firstPersonShadows, PlayerData),
"@brief Forces shadows to be rendered in first person when renderFirstPerson is disabled. Defaults to false.\n\n" );
addField( "minLookAngle", TypeF32, Offset(minLookAngle, PlayerData),
"@brief Lowest angle (in radians) the player can look.\n\n"
"@note An angle of zero is straight ahead, with positive up and negative down." );
......@@ -1180,7 +1184,8 @@ void PlayerData::packData(BitStream* stream)
......@@ -1361,6 +1366,7 @@ void PlayerData::unpackData(BitStream* stream)
renderFirstPerson = stream->readFlag();
firstPersonShadows = stream->readFlag();
......@@ -6947,6 +6953,11 @@ void Player::prepRenderImage( SceneRenderState* state )
GameConnection* connection = GameConnection::getConnectionToServer();
if( connection && connection->getControlObject() == this && connection->isFirstPerson() )
// If we're first person and we are not rendering the player
// then disable all shadow rendering... a floating gun shadow sucks.
if ( state->isShadowPass() && !mDataBlock->renderFirstPerson && !mDataBlock->firstPersonShadows )
renderPlayer = mDataBlock->renderFirstPerson || !state->isDiffusePass();
if( !sRenderMyPlayer )
......@@ -54,6 +54,10 @@ struct PlayerData: public ShapeBaseData {
bool renderFirstPerson; ///< Render the player shape in first person
/// Render shadows while in first person when
/// renderFirstPerson is disabled.
bool firstPersonShadows;
StringTableEntry imageAnimPrefix; ///< Passed along to mounted images to modify
/// animation sequences played in third person. [optional]
bool allowImageStateAnimation; ///< When true a new thread is added to the player to allow for
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment