Skip to content
Snippets Groups Projects
Commit a65233d4 authored by Hiroki Tagato's avatar Hiroki Tagato
Browse files

devel/electron32: fix build with ICU 76

parent 64c27d42
No related branches found
No related tags found
No related merge requests found
--- .gn.orig 2025-01-29 08:44:44 UTC
+++ .gn
@@ -173,6 +173,8 @@ exec_script_whitelist =
"//tools/grit/grit_rule.gni",
"//tools/gritsettings/BUILD.gn",
+ "//third_party/icu/BUILD.gn",
+
"//electron/BUILD.gn",
"//third_party/electron_node/deps/base64/BUILD.gn",
"//third_party/electron_node/deps/base64/unofficial.gni",
--- build/linux/unbundle/icu.gn.orig 2023-04-04 21:42:43 UTC
--- build/linux/unbundle/icu.gn.orig 2024-11-06 12:34:11 UTC
+++ build/linux/unbundle/icu.gn
@@ -17,6 +17,15 @@ config("icu_config") {
"USING_SYSTEM_ICU=1",
......@@ -16,3 +16,22 @@
# U_EXPORT (defined in unicode/platform.h) is used to set public visibility
# on classes through the U_COMMON_API and U_I18N_API macros (among others).
# When linking against the system ICU library, we want its symbols to have
@@ -35,6 +44,18 @@ config("icu_config") {
# please see: https://crbug.com/822820
"U_IMPORT=U_EXPORT",
]
+
+ _icu_version = exec_script(pkg_config_script,
+ common_pkg_config_args + pkg_config_args + [
+ "icu-i18n",
+ "--version-as-components",
+ ],
+ "value")
+
+ # Unbreak with icu 76 where private symbols are picked up
+ if (_icu_version[0] >= 76) {
+ defines += [ "U_HIDE_DRAFT_API" ]
+ }
}
pkg_config("system_icui18n") {
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment