Skip to content

Bugfix fenix-engine-cli package in npm repo

ltngames requested to merge update-package into master
  • Update dev dependencies

Broken fenix-engine-cli package

  • Release 0.3.0 in npm repo would not install due to the package.json files property not being absolute

  • bugfix for fenix-engine-cli breaking when using npm install, even though npm link works fine. Running any command would cause the file to open and not execture. I've tracked the bug to the shebang at the top of the final bundle of the cli, RollupJS has 2 properties intro and banner I used intro where it should've been banner.

Installing the package locally from the repository revealed a couple more bugs.

  • logger attempts to require package.json but because it's doing dirname of the root dir, it;s causing it to look in node_module and not fenix-engine-cli

  • parseShortPath has an argument named path but the module also imports path causing a collision between the function and the imported module. This conflict caused the development server to crash. Fix is to change the function's argument path to fullPath

Edited by ltngames

Merge request reports