Commit 320ca7b1 authored by Ariadne Conill's avatar Ariadne Conill

user: when processing a block in User.block(), ensure all follow relationships are broken

this is needed for activitypub conformance

ref #213
parent 25946f77
......@@ -505,12 +505,25 @@ defmodule Pleroma.User do
Repo.all(q)
end
def block(user, %{ap_id: ap_id}) do
blocks = user.info["blocks"] || []
def block(blocker, %User{ap_id: ap_id} = blocked) do
# sever any follow relationships to prevent leaks per activitypub (Pleroma issue #213)
blocker =
if following?(blocker, blocked) do
{:ok, blocker, _} = unfollow(blocker, blocked)
blocker
else
blocker
end
if following?(blocked, blocker) do
unfollow(blocked, blocker)
end
blocks = blocker.info["blocks"] || []
new_blocks = Enum.uniq([ap_id | blocks])
new_info = Map.put(user.info, "blocks", new_blocks)
new_info = Map.put(blocker.info, "blocks", new_blocks)
cs = User.info_changeset(user, %{info: new_info})
cs = User.info_changeset(blocker, %{info: new_info})
update_and_set_cache(cs)
end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment