Please don't put unrelated changes into one commit and write meaningful commit messages
This is a follow-up to #112 (closed).
When you look at the commit-graph https://gitlab.com/CardBook/CardBook/network/32.6, you see the following:
- 7 (seven!) commits with the message "version 32.6", most of these commits contain functional changes.
- a commit (a5526d37) with message "release 32.5", containing functional changes in 8 files.
- a commit (48409371) with message "release 32.4", containing functional changes in29 files.
This makes it hard, if not impossible, to get a notion of what has changed. E.g. what has changed for 35.6? This is esp. worse since there are not release-notes.
What I expect
Each commit shall stand alone as a single, complete, logical change and have a descriptive commit message.
Commits related to releasing a new version shall not be mixed with functional changes.
Rational
Meaningful commit-messages are important to make users confident into a project and to help other developers to contribute. Other developers can learn from the commits. E.g. one can see what has changed in a release. And thus one can try to verify if a bug which is said to be fixed might actually be fixed.
Meaningful commit-messages can also act as some kind of release-notes.
Tips
You may want to have a look at https://pyinstaller.readthedocs.io/en/v3.4/development/commit-messages.html to get a notion of what I mean. For CardBook relaxed rules for commit messages might suffice, but the basic idea remains: A commit stands alone as a single, complete, logical change and has a descriptive commit message.
An example for a one-person-project using basically the same idea but relax rules can be found at https://gitlab.com/htgoebel/OSD-Neo2/network/master