Bschubert/backport log missed cache (!752) · Merge requests · BuildStream / buildstream

Merged Benjamin Schubert requested to merge bschubert/backport-log-missed-cache into bst-1.2 6 years ago

All threads resolved!

Description

This is a backport for branch 1.2 from !729 (merged)

When an artifact was pulled from the cache but ended up missing, nothing would say to the user that the fetch couldn't be made because the entry did not exist. This adds a logging step in that case.

Changes proposed in this merge request:

Log missing entry when downloading from cache
Add tests for it

This merge request, when approved, will close issue/bug: #594 (closed)

A sample output now is:

[--:--:--][7830525c][ pull:import-bin.bst                ] START   test/import-bin/7830525c-pull.17578.log
[--:--:--][04f1033c][ pull:target.bst                    ] START   test/target/04f1033c-pull.17579.log
[--:--:--][7830525c][ pull:import-bin.bst                ] INFO    Pulling 7830525c <- http://localhost:38115
[--:--:--][04f1033c][ pull:target.bst                    ] INFO    Pulling 04f1033c <- http://localhost:38115
[--:--:--][7830525c][ pull:import-bin.bst                ] SKIPPED Remote (http://localhost:38115) does not have 7830525c cached
[00:00:00][7830525c][ pull:import-bin.bst                ] SUCCESS test/import-bin/7830525c-pull.17578.log
[--:--:--][04f1033c][ pull:target.bst                    ] SKIPPED Remote (http://localhost:38115) does not have 04f1033c cached
[00:00:00][04f1033c][ pull:target.bst                    ] SUCCESS test/target/04f1033c-pull.17579.log
[--:--:--][2752ad79][ pull:compose-all.bst               ] START   test/compose-all/2752ad79-pull.17588.log
[--:--:--][][] START   cache_size.17589.log
[00:00:00][][] SUCCESS cache_size.17589.log
[--:--:--][2752ad79][ pull:compose-all.bst               ] INFO    Pulling 2752ad79 <- http://localhost:38115
[--:--:--][2752ad79][ pull:compose-all.bst               ] SKIPPED Remote (http://localhost:38115) does not have 2752ad79 cached
[00:00:00][2752ad79][ pull:compose-all.bst               ] SUCCESS test/compose-all/2752ad79-pull.17588.log
[--:--:--][][] START   cache_size.17595.log
[00:00:00][][] SUCCESS cache_size.17595.log
[--:--:--][692af684][ pull:import-dev.bst                ] START   test/import-dev/692af684-pull.17596.log
[--:--:--][692af684][ pull:import-dev.bst                ] INFO    Pulling 692af684 <- http://localhost:38115
[--:--:--][692af684][ pull:import-dev.bst                ] SKIPPED Remote (http://localhost:38115) does not have 692af684 cached
[00:00:00][692af684][ pull:import-dev.bst                ] SUCCESS test/import-dev/692af684-pull.17596.lo