Skip to content

WIP: Upstream freedesktop-sdk strip rules

Tom Coldrick requested to merge coldtom/strip-rules into master

Description

This upstreams a modified version of freedesktop-sdk's rules for stripping binaries. In the course of the project a few changes were applied to fix bugs or add functionality to the strip rules. In particular an issue was solved due to permissions.

I have modified the script from how it appears in freedesktop-sdk as follows:

  • Removed our additions for debugedit
  • Added a switch to allow fail on error, rather than having that as default

I think this now should be a sensible default configuration for buildstream. I'm not overly attached to the switch to fail on error, and wouldn't be opposed to its removal altogether. Additionally I'd like a good amount of review to make sure the modifications I made won't break things, and will behave as intended.

Changes proposed in this merge request:

  • Update strip rules to a version including bug fixes from freedesktop-sdk
  • Add a switch to allow users to cause a failure when the strip rules fail

This merge request, when approved, will close issue/bug: freedesktop-sdk/freedesktop-sdk#343 (closed)

Also fixes #645 (closed)

Edited by Javier Jardón

Merge request reports