Skip to content
Snippets Groups Projects

Check for write access to remote artifact cache early on in the pipeline

Merged Sam Thursfield requested to merge sam/artifactcache-preflight-check into master
All threads resolved!

Previously, the first time you configured an artifact cache, you would get to the end of your first build and then BuildStream would exit because of some stupid mistake like you got the address slightly wrong or you forgot to add the host keys of the remote artifact cache to ~/.ssh/known_hosts.

To avoid surprises, if there's an artifacts push-url configured we now try to connect to it as a preflight check so that issues are raised early.

As a bonus, for some reason this check causes SSH to ask about unknown host keys rather than just failing, so you may now see messages like this if the host keys are unknown rather than an error:

The authenticity of host '[ostree.baserock.org]:22200 ([185.43.218.170]:22200)' can't be established.
ECDSA key fingerprint is SHA256:mB+MNfYREOdRfp2FG6dceOlguE/Skd4QwnS0tvCPcnI.
ECDSA key fingerprint is MD5:8f:fa:ab:90:19:31:f9:f7:f1:d4:e5:f0:a2:be:56:71.
Are you sure you want to continue connecting (yes/no)?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tristan Van Berkom
  • Sam Thursfield added 62 commits

    added 62 commits

    • fcb4a7c6...97721079 - 61 commits from branch master
    • c5c7893a - Check for write access to remote artifact cache early on in the pipeline

    Compare with previous version

  • New version with these changes:

    • Rebased on top of master
    • Updated to work with new artifact cache protocol
    • Moved the check into the pipeline.build() method, and made it a proper timed activity with a clearer error message
    • Other small cleanups raised above
  • Sam Thursfield added 1 commit

    added 1 commit

    • cb54f531 - Check for write access to remote artifact cache early on in the pipeline

    Compare with previous version

  • Sam Thursfield added 1 commit

    added 1 commit

    • 8427fbc7 - Check for write access to remote artifact cache early on in the pipeline

    Compare with previous version

  • Jürg Billeter
  • Sam Thursfield added 1 commit

    added 1 commit

    • 2b700e8b - Check for write access to remote artifact cache early on in the pipeline

    Compare with previous version

  • Sam Thursfield added 1 commit

    added 1 commit

    • cd33dd37 - Check for write access to remote artifact cache early on in the pipeline

    Compare with previous version

  • Sam Thursfield resolved all discussions

    resolved all discussions

  • Thanks both for the patient reviews and testing. I have seen this push to ostree.baserock.org successfully on my machine now. Am not entirely sure how my testing went so wrong...

  • Sam Thursfield added 1 commit

    added 1 commit

    • 14a8b5aa - Check for write access to remote artifact cache early on in the pipeline

    Compare with previous version

  • Jürg Billeter enabled an automatic merge when the pipeline for 14a8b5aa succeeds

    enabled an automatic merge when the pipeline for 14a8b5aa succeeds

  • Please register or sign in to reply
    Loading