element.py: Fix consistency of workspaced elements when ref is missing
Fixes #393 (closed).
Merge request reports
Activity
- Resolved by Chandan Singh
I like how existence of the workspace on disk is used here to determine consistency.
I wonder if
Consistency.INCONSISTENT
(usually taken to mean we have no clue even what it is) is the right choice overConsistency.RESOLVED
(taken to mean we know what it is, but we just dont have it)I think I like your choice here, we cannot really ever know what it is, if it is a workspace.
This might however have a side effect of the user might get suggested "Hey, we dont know what this is, how about you try
bst track
on this element ?", then again I guess the same would be true regardless of the choice ofINCONSISTENT
orRESOLVED
- lets deal with those edge cases separately, there are probably some error messages which need to change for inconsistent workspaced elements.Edited by Tristan Van Berkomadded 11 commits
-
6e718c02...e023beb5 - 9 commits from branch
master
- ecc1d074 - element.py: Fix consistency of workspaced elements when ref is missing
- b35ee809 - fixup! element.py: Fix consistency of workspaced elements when ref is missing
-
6e718c02...e023beb5 - 9 commits from branch
added 1 commit
- 00230948 - fixup! fixup! element.py: Fix consistency of workspaced elements when ref is missing
added 1 commit
- ba6eaba6 - element.py: Fix consistency of workspaced elements when ref is missing
enabled an automatic merge when the pipeline for 314c25d8 succeeds