Skip to content
Snippets Groups Projects

element.py: Fix consistency of workspaced elements when ref is missing

Merged Chandan Singh requested to merge chandan/393-fix-workspace-no-reference into master
All threads resolved!

Fixes #393 (closed).

Edited by Chandan Singh

Merge request reports

Pipeline #22193055 passed

Pipeline passed for 314c25d8 on chandan/393-fix-workspace-no-reference

Test coverage 84.70% (-0.01%) from 1 job

Merged by Tristan Van BerkomTristan Van Berkom 6 years ago (May 17, 2018 1:58pm UTC)

Loading

Pipeline #22196525 passed

Pipeline passed for 314c25d8 on master

Test coverage 84.70% (-0.01%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I like how existence of the workspace on disk is used here to determine consistency.

    I wonder if Consistency.INCONSISTENT (usually taken to mean we have no clue even what it is) is the right choice over Consistency.RESOLVED (taken to mean we know what it is, but we just dont have it)

    I think I like your choice here, we cannot really ever know what it is, if it is a workspace.

    This might however have a side effect of the user might get suggested "Hey, we dont know what this is, how about you try bst track on this element ?", then again I guess the same would be true regardless of the choice of INCONSISTENT or RESOLVED - lets deal with those edge cases separately, there are probably some error messages which need to change for inconsistent workspaced elements.

    Edited by Tristan Van Berkom
  • Chandan Singh marked as a Work In Progress

    marked as a Work In Progress

  • Chandan Singh added 11 commits

    added 11 commits

    • 6e718c02...e023beb5 - 9 commits from branch master
    • ecc1d074 - element.py: Fix consistency of workspaced elements when ref is missing
    • b35ee809 - fixup! element.py: Fix consistency of workspaced elements when ref is missing

    Compare with previous version

  • Chandan Singh added 1 commit

    added 1 commit

    • 00230948 - fixup! fixup! element.py: Fix consistency of workspaced elements when ref is missing

    Compare with previous version

  • Chandan Singh added 1 commit

    added 1 commit

    • ba6eaba6 - element.py: Fix consistency of workspaced elements when ref is missing

    Compare with previous version

  • Chandan Singh unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Chandan Singh resolved all discussions

    resolved all discussions

  • Tristan Van Berkom resolved all discussions

    resolved all discussions

  • added 2 commits

    • 84a57b2f - 1 commit from branch master
    • 314c25d8 - element.py: Fix consistency of workspaced elements when ref is missing

    Compare with previous version

  • Tristan Van Berkom enabled an automatic merge when the pipeline for 314c25d8 succeeds

    enabled an automatic merge when the pipeline for 314c25d8 succeeds

  • Please register or sign in to reply
    Loading