Skip to content
Snippets Groups Projects

Allow 'None' as a default_value for _yaml.node_get

Merged Allow 'None' as a default_value for _yaml.node_get
node-get-default into master
All threads resolved!
Merged Tristan Maat requested to merge node-get-default into master
All threads resolved!

Merge request reports

Pipeline #20127033 passed

Stage: prepare
Stage: test
Stage: post

Pipeline passed for 3ba544b8 on node-get-default

Merged by Tristan Van BerkomTristan Van Berkom 6 years ago (Apr 7, 2018 10:25am UTC)

Merge details

  • Changes merged into master with 3ba544b8.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #20127490 passed with warnings

Stage: prepare
Stage: test
Stage: post
Stage: deploy

Pipeline passed with warnings for 3ba544b8 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tristan Van Berkom
  • Tristan Maat resolved all discussions

    resolved all discussions

  • Tristan Maat added 1 commit

    added 1 commit

    • 1e5ac4ae - Allow 'None' as a default_value for _yaml.node_get

    Compare with previous version

  • Tristan Maat added 1 commit

    added 1 commit

    • 55aedba1 - Allow 'None' as a default_value for _yaml.node_get

    Compare with previous version

  • Tristan Van Berkom added 4 commits

    added 4 commits

    Compare with previous version

  • Tristan Van Berkom enabled an automatic merge when the pipeline for 3ba544b8 succeeds

    enabled an automatic merge when the pipeline for 3ba544b8 succeeds

  • Tristan Van Berkom
    Tristan Van Berkom @tristanvb
    Owner

    Looks like you missed the plugins here :(

  • Tristan Van Berkom merged

    merged

  • Tristan Van Berkom
    Tristan Van Berkom @tristanvb
    Owner

    I took care of it and added this commit on top of this MR:

    commit 60dbf19ffbc9ec4300acc79689d173af7c830c0c
Author: Tristan Van Berkom <tristan.vanberkom@codethink.co.uk>
Date:   Sat Apr 7 19:18:50 2018 +0900

    Complete the work started to allow None as default in _yaml.node_get()
    
    This completes the work which was started in commit
    3ba544b80f9f268be8ffe62fc8589b30212ec4a2 which only went half
    way towards updating all the source code to be consistent and use
    the new semantic which allows None values.
    • Please register or sign in to reply